docs: add explicit breadcrumbs i18n property to typings#11968
Merged
Conversation
sissbruecker
approved these changes
Jun 23, 2026
|
sissbruecker
pushed a commit
that referenced
this pull request
Jun 23, 2026
… 25.2) (#11969) This PR cherry-picks changes from the original PR #11968 to branch 25.2. --- #### Original PR description > ## Description > > - Changed to use `I18nMixin<typeof HTMLElement, BreadcrumbsI18n>` to align with `vaadin-dashboard.d.ts` > - `I18nMixin` needs to be innermost, otherwise it will suppress other mixins due to `typeof HTMLElement` > - Added `i18n` property to `vaadin-breadcrumbs.d.ts` to show correct defaults in IDE code completion: > > <img width="704" height="194" alt="i18n" src="https://github.com/user-attachments/assets/133df8c5-4e5d-405e-b6fc-09f632f55645" /> > > > > ## Type of change > > - Documentation Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I18nMixin<typeof HTMLElement, BreadcrumbsI18n>to align withvaadin-dashboard.d.tsI18nMixinneeds to be innermost, otherwise it will suppress other mixins due totypeof HTMLElementi18nproperty tovaadin-breadcrumbs.d.tsto show correct defaults in IDE code completion:Type of change