Skip to content

fix: apply background and border styles on the host#11980

Merged
web-padawan merged 5 commits into
mainfrom
fix/aura-rte-border
Jun 25, 2026
Merged

fix: apply background and border styles on the host#11980
web-padawan merged 5 commits into
mainfrom
fix/aura-rte-border

Conversation

@jouni

@jouni jouni commented Jun 25, 2026

Copy link
Copy Markdown
Member

Fixes #11957

@jouni jouni requested a review from web-padawan June 25, 2026 13:16
@jouni jouni force-pushed the fix/aura-rte-border branch from a64ab57 to a6a61bf Compare June 25, 2026 13:27
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the screenshot, the border is now a bit clipped near the scroll bar. I wonder if we can somehow prevent that as it doesn't look this way e.g. in tabsheet?

@jouni

jouni commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Ah, thanks for noticing. I’ll fix it.

@jouni jouni force-pushed the fix/aura-rte-border branch from 7b3793b to 47b600d Compare June 25, 2026 13:37

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why I can't get this screenshot to update. It looks correct locally.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated all screenshots for RTE by removing and re-generating to pick up new state.

@web-padawan web-padawan merged commit a90c2ea into main Jun 25, 2026
10 checks passed
@web-padawan web-padawan deleted the fix/aura-rte-border branch June 25, 2026 14:08
@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @jouni and @web-padawan, when i performed cherry-pick to this commit to 25.2, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a90c2ea
error: could not apply a90c2ea... fix: apply RTE background and border styles on the host (#11980)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rich text editor has sharp edges in Aura themed application

3 participants