refactor: remove dead no-scrollbars styles from grid#11983
Merged
Conversation
vursen
changed the title
The no-scrollbars scrollbar-hiding rule dates back to the old outer-scroller architecture. The `no-scrollbars` attribute it depends on is no longer set on the scroller, so the `[no-scrollbars][safari]` / `[firefox]` rules in the base and Lumo styles never match. The `firefox` attribute was dropped even earlier, and the `_firefox` property lost its last reader in #6673, leaving the property and its isFirefox import dead too. Remove the dead rules, the _firefox property, and the unused isFirefox import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vursen
force-pushed
the
chore/remove-dead-grid-firefox-detection
branch
from
4af5fe7 to
42297a1
Compare
vursen
changed the title
vursen
changed the title
vursen
changed the title
vursen
commented
Jun 26, 2026
| }, | ||
|
|
||
| /** @private */ | ||
| _firefox: { |
Contributor
Author
There was a problem hiding this comment.
The _firefox property isn't read from anywhere and actually stopped being reflected as an attribute a long time ago, so it can also be removed.
web-padawan
approved these changes
Jun 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR removes the
[no-scrollbars]CSS rule because this attribute isn't set from anywhere. According to Claude, it's a leftover from the old outer-scroller architecture which was abandoned a long time ago.