APP-16894: Add min_viam_server_version to registry item protos#877
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Julie Krasnick (jckras)
force-pushed
the
minServerCompat
branch
from
c8d9443 to
0fd6f48
Compare
Julie Krasnick (jckras)
added
the
ready-for-protos
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Julie Krasnick (jckras)
requested review from
Evgeni Dobranov (edobranov) and
Michael Lee (michaellee1019)
Michael Lee (michaellee1019)
approved these changes
Jul 9, 2026
Evgeni Dobranov (edobranov)
approved these changes
Jul 9, 2026
Member
Author
|
succesfully tested these api changes. see the pr description in this APP pr for proof: https://github.com/viamrobotics/app/pull/12704 |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Julie Krasnick (jckras)
removed
the
ready-for-protos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(https://viam.atlassian.net/browse/APP-16894) - This PR adds an optional
min_viam_server_versionstring (semver, ex "0.62.0") to the registry-item API surface.ModuleMetadata: the module’s current value. This is what GetRegistryItem returns for a module. The registry page displays it from here, and the machine-config search banner (which I will be adding) will compare against it when you’re adding a module (new adds default to latest, so the current value is the right one to check).ModuleVersion: the frozen per-version value. ModuleMetadata contains a list of these. One per published version. Since each version freezes the value at publish time, the module card banner (which I will be adding) will read the specific configured version’s value from here.UpdateModuleMetadata: how the value gets set. When a module owner edits their module on the registry page, the frontend sends an UpdateRegistryItemRequest, and module-specific edits travel inside this message. Adding the field here gives the registry page a way to write it.Additive and non-breaking. No changes to module APIs (UpdateModuleRequest, VersionHistory, etc.) the CLI is untouched.
This app PR (APP-16895) is built against this branch so we can more easily test these api changes.