TMCRootManager: implemented RNTuple writer#28
Open
karabowi wants to merge 5 commits into
Open
Conversation
ihrivnac
reviewed
Jun 26, 2026
Author
|
I have applied the requested changes. |
ihrivnac
reviewed
Jul 16, 2026
Comment on lines
+39
to
+40
| using RNTupleFillContext = ROOT::Experimental::RNTupleFillContext; | ||
| using RNTParaWriter = ROOT::Experimental::RNTupleParallelWriter; |
Contributor
There was a problem hiding this comment.
The Experimental:: was removed since ROOT v6.38.00; when I compiled with ROOT v6.40.02, this was causing compilation error.
As we should not require ROOT build with experimental features (ROOT 7) for building vmc, I suggest to remove Experimental:: and add a test for ROOT version
#if (ROOT_VERSION_CODE >= ROOT_VERSION(6, 38, 0)))
using RNTupleFillContext = ROOT::Experimental::RNTupleFillContext;
using RNTParaWriter = ROOT::Experimental::RNTupleParallelWriter;
#endifand also around the code requiring these classes below.
Contributor
There was a problem hiding this comment.
Thank you for this update. I can now compile vmc with ROOT versions v6.36.14 and v6.40.02; but the E03d example in vmc-project/geant4_vmc#85 does not compile with v6.36.14.
So I prefer to wait with merging when both PRs will work together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the TMCRootManager store data in TTree or RNTuple format.