Skip to content

feat(deps): upgrade upstream dependencies#1693

Merged
fengmk2 merged 12 commits into
mainfrom
deps/upstream-update
May 27, 2026
Merged

feat(deps): upgrade upstream dependencies#1693
fengmk2 merged 12 commits into
mainfrom
deps/upstream-update

Conversation

@voidzero-guard
Copy link
Copy Markdown
Contributor

Summary

  • Automated daily upgrade of upstream dependencies.
  • Bumps the oxc toolchain group: oxlint 1.66.0 -> 1.67.0, oxfmt 0.51.0 -> 0.52.0, and @oxc-project/* / oxc-* packages 0.132.0 -> 0.133.0.
  • Refreshes CLI snapshots affected by the new oxlint --debug=files option and updated vp run cache-status messages.

Dependency updates

Package From To
oxfmt 0.51.0 0.52.0
oxlint 1.66.0 1.67.0
@oxc-project/runtime 0.132.0 0.133.0
@oxc-project/types 0.132.0 0.133.0
oxc-minify 0.132.0 0.133.0
oxc-parser 0.132.0 0.133.0
oxc-transform 0.132.0 0.133.0
Unchanged dependencies
  • rolldown: v1.0.2 (f2757ed)
  • vite: v8.0.14 (c917f1e)
  • vitest: 4.1.7
  • tsdown: 0.22.0
  • @oxc-node/cli: 0.1.0
  • @oxc-node/core: 0.1.0
  • oxlint-tsgolint: 0.23.0
  • @vitejs/devtools: 0.2.0

Code changes

  • Refresh oxlint help-output snapshots for the new --debug=files option in packages/cli/snap-tests/bin-oxlint-wrapper/snap.txt and packages/cli/snap-tests/command-helper/snap.txt.
  • Refresh vp run cache-status output snapshots in packages/cli/snap-tests/cache-clean/snap.txt, packages/cli/snap-tests/ignore_dist/snap.txt, and packages/cli/snap-tests/plain-terminal-ui-nested/snap.txt.

Build status

  • sync-remote-and-build: success
  • build-upstream: success

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 0a7575e
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a16f046c3f243000893599e

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 27, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​oxc-project/​runtime@​0.133.01001007596100
Addednpm/​oxfmt@​0.52.0991009296100
Addednpm/​oxc-transform@​0.133.0941009696100
Addednpm/​oxc-parser@​0.133.09910010095100

View full report

Copy link
Copy Markdown
Member

fengmk2 commented May 27, 2026

Investigation result for the packages/cli/snap-tests/oxlint-typeaware failure:

The snap itself is not failing because of the type-aware cache/input logic. It fails earlier because vp lint --type-aware ./src exits while oxlint is loading the Vite+ config.

oxlint@1.67.0 now declares an optional vite-plus peer and loads Vite+ config via import("vite-plus").resolveConfig. In CI, that path imports vite-plus -> @voidzero-dev/vite-plus-core, then reaches:

@voidzero-dev/vite-plus-core/dist/rolldown/shared/resolve-tsconfig-DCdBlPeK.mjs:103
var TsconfigCache = class extends import_binding.TsconfigCache
TypeError: Class extends value undefined is not a constructor or null

The underlying issue appears to be the published @voidzero-dev/vite-plus-core@0.1.22 Rolldown binding loader falling back to vite-plus/binding. That vite-plus/binding is the Vite+ CLI NAPI binding, not the Rolldown binding, so it does not export Rolldown symbols such as TsconfigCache; import_binding.TsconfigCache is therefore undefined.

This is why oxlint-typeaware shows the failure: the fixture runs vp lint --type-aware ./src, and oxlint 1.67.0 now tries to parse vite.config.ts through Vite+ before linting or cache behavior is exercised.

I could not reproduce with the existing local install because this workspace still had oxlint@1.66.0; CI installs the PR lockfile dependency graph, where oxlint@1.67.0 takes the new Vite+ config loading path.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 27, 2026

Open in StackBlitz

vite-plus

npm i https://pkg.pr.new/voidzero-dev/vite-plus@1693

@voidzero-dev/vite-plus-core

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1693

@voidzero-dev/vite-plus-prompts

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@1693

@voidzero-dev/vite-plus-test

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1693

@voidzero-dev/vite-plus-cli-darwin-arm64

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-darwin-arm64@1693

@voidzero-dev/vite-plus-cli-darwin-x64

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-darwin-x64@1693

@voidzero-dev/vite-plus-cli-linux-arm64-gnu

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-linux-arm64-gnu@1693

@voidzero-dev/vite-plus-cli-linux-arm64-musl

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-linux-arm64-musl@1693

@voidzero-dev/vite-plus-cli-linux-x64-gnu

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-linux-x64-gnu@1693

@voidzero-dev/vite-plus-cli-linux-x64-musl

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-linux-x64-musl@1693

@voidzero-dev/vite-plus-cli-win32-arm64-msvc

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-win32-arm64-msvc@1693

@voidzero-dev/vite-plus-cli-win32-x64-msvc

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-cli-win32-x64-msvc@1693

@voidzero-dev/vite-plus-darwin-arm64

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-darwin-arm64@1693

@voidzero-dev/vite-plus-darwin-x64

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-darwin-x64@1693

@voidzero-dev/vite-plus-linux-arm64-gnu

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-linux-arm64-gnu@1693

@voidzero-dev/vite-plus-linux-arm64-musl

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-linux-arm64-musl@1693

@voidzero-dev/vite-plus-linux-x64-gnu

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-linux-x64-gnu@1693

@voidzero-dev/vite-plus-linux-x64-musl

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-linux-x64-musl@1693

@voidzero-dev/vite-plus-win32-arm64-msvc

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-win32-arm64-msvc@1693

@voidzero-dev/vite-plus-win32-x64-msvc

npm i https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-win32-x64-msvc@1693

commit: fba9834

Comment thread ecosystem-ci/verify-install.ts Outdated
Copy link
Copy Markdown
Member

fengmk2 commented May 27, 2026

Fixed in 76d19125 (fix(cli): build local binding with rolldown).

Root cause was that local/dev vite-plus native binding was built without the rolldown feature, so when oxlint's type-aware config loading imported local vite-plus, Rolldown's TsconfigCache / resolveTsconfig exports were missing. The PR now builds the local binding with rolldown enabled and updates the generated binding stubs. I also adjusted the oxlint-typeaware fixture so it remains lint-clean once config loading succeeds.

Local verification:

  • pnpm -F vite-plus build-native
  • pnpm -F vite-plus snap-test-local oxlint-typeaware
  • snapshot diff for packages/cli/snap-tests/oxlint-typeaware/snap.txt stayed clean

Comment thread packages/cli/build.ts Outdated
voidzero-guard Bot and others added 6 commits May 27, 2026 19:48
- oxfmt: 0.51.0 -> 0.52.0
- oxlint: 1.66.0 -> 1.67.0
- @oxc-project/runtime: 0.132.0 -> 0.133.0
- @oxc-project/types: 0.132.0 -> 0.133.0
- oxc-minify: 0.132.0 -> 0.133.0
- oxc-parser: 0.132.0 -> 0.133.0
- oxc-transform: 0.132.0 -> 0.133.0

Code changes:
- Refresh oxlint help output snapshots for new `--debug=files` option in packages/cli/snap-tests/bin-oxlint-wrapper/snap.txt and packages/cli/snap-tests/command-helper/snap.txt
- Refresh vp run cache-status output snapshots in packages/cli/snap-tests/cache-clean/snap.txt, packages/cli/snap-tests/ignore_dist/snap.txt, and packages/cli/snap-tests/plain-terminal-ui-nested/snap.txt
@fengmk2 fengmk2 requested a review from Brooooooklyn May 27, 2026 11:49
@fengmk2

This comment was marked as outdated.

@fengmk2 fengmk2 force-pushed the deps/upstream-update branch from 9dd35dc to fba9834 Compare May 27, 2026 11:50
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 27, 2026

@codex review

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests labels May 27, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fba98342a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/build.ts Outdated
Comment thread pnpm-lock.yaml Outdated
Comment thread packages/cli/snap-tests/ignore_dist/snap.txt Outdated
Comment thread packages/cli/snap-tests/cache-clean/snap.txt Outdated
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented May 27, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fengmk2 added 2 commits May 27, 2026 21:18
- Drop dead `bindingFeatures.includes('rolldown')` conditional in
  packages/cli/build.ts: the array is hardcoded to `['rolldown']`, so the
  false branch and the subsequent empty-string guard were unreachable.
- ecosystem-ci/verify-install.ts: fail loudly when vite-plus is missing the
  oxlint dependency instead of silently skipping the version check; broaden
  the semver-operator strip from `=` to `=|^|~` so future catalog format
  changes don't spuriously fail; drop the no-op `path.sep` prefix on the
  pnpm `.pnpm/vite-plus@file+` substring check.
Mirror the e2e-test.yml gate so create-e2e runs automatically on every
push to deps/upstream-update without needing the `test: create-e2e`
label. Upstream dependency upgrades can shift create/migrate behavior
even when no files under packages/cli/src/create/** change.
@fengmk2 fengmk2 merged commit f0f63e3 into main May 27, 2026
115 checks passed
@fengmk2 fengmk2 deleted the deps/upstream-update branch May 27, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg.pr.new test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant