fix(global): install packages into final prefix#1698
Draft
liangmiQwQ wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
liangmiQwQ
changed the title
liangmiQwQ
force-pushed
the
codex/install-global-direct-prefix
branch
from
21941bc to
3e97d03
Compare
liangmiQwQ
force-pushed
the
codex/install-global-direct-prefix
branch
from
3e97d03 to
a37bd9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #664
The current global package install flow runs
npm install -gin a temporary prefix and then moves the installed package prefix intoVP_HOME/packages. npm creates global bin links relative to the prefix used during installation, so moving that prefix can leave installed binaries pointing at the wrong location.This PR installs global packages directly into their final package prefix. It removes an existing same-name managed package before install, writes package metadata during the parallel install phase, then checks bin conflicts and creates shims after installs finish.
If one package in a multi-package install fails, this PR still finalizes shims for packages that already installed successfully instead of deleting them or leaving them without runnable bins.
This PR also updates the local/tarball global install snapshot to execute installed bins and cover the partial-failure case.
🤖 Generated with Codex.