perf: executor use execute_parent kernel registry in execute_until#8448
Open
joseph-isaacs wants to merge 7 commits into
Open
perf: executor use execute_parent kernel registry in execute_until#8448joseph-isaacs wants to merge 7 commits into
execute_until#8448joseph-isaacs wants to merge 7 commits into
Conversation
robert3005
reviewed
Jun 16, 2026
robert3005
approved these changes
Jun 16, 2026
Merging this PR will degrade performance by 10.86%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
162.1 µs | 199.8 µs | -18.89% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
178.2 µs | 215.2 µs | -17.21% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
274 µs | 315.8 µs | -13.25% |
| ❌ | Simulation | search_index_above_max |
256 µs | 292.2 µs | -12.4% |
| ❌ | Simulation | search_index_below_min |
256 µs | 292.2 µs | -12.4% |
| ❌ | Simulation | search_index_full_range_random |
256.2 µs | 292.4 µs | -12.38% |
| ❌ | Simulation | search_index_in_range |
256.4 µs | 292.6 µs | -12.37% |
| ❌ | Simulation | search_index_mixed_out_of_range |
256.2 µs | 292.3 µs | -12.36% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
215.3 ns | 244.4 ns | -11.93% |
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(100, 100)] |
358.3 µs | 403.9 µs | -11.3% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
332.9 µs | 373.1 µs | -10.77% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
214.7 µs | 179 µs | +19.96% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ji/perf-executor-execute-parent (8914550) with develop (202953d)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
joseph-isaacs
added
the
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.045x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.045x ➖, 0↑ 2↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.081x ➖, 0↑ 3↓)
datafusion / vortex-compact (1.009x ➖, 1↑ 1↓)
datafusion / parquet (1.038x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.100x ➖, 0↑ 4↓)
duckdb / vortex-compact (1.047x ➖, 0↑ 0↓)
duckdb / parquet (1.057x ➖, 0↑ 2↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.989x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.989x ➖, 0↑ 0↓)
datafusion / parquet (0.969x ➖, 1↑ 0↓)
datafusion / arrow (0.984x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (0.982x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.986x ➖, 0↑ 0↓)
duckdb / parquet (1.015x ➖, 0↑ 4↓)
duckdb / duckdb (0.988x ➖, 0↑ 0↓)
File Size Changes (11 files changed, +0.0% overall, 6↑ 5↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.995x ➖, 3↑ 1↓)
datafusion / vortex-compact (0.995x ➖, 2↑ 1↓)
datafusion / parquet (0.993x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (1.001x ➖, 2↑ 2↓)
duckdb / vortex-compact (0.996x ➖, 2↑ 1↓)
duckdb / parquet (1.000x ➖, 0↑ 0↓)
duckdb / duckdb (0.996x ➖, 1↑ 0↓)
File Size Changes (7 files changed, -0.0% overall, 2↑ 5↓)
Totals:
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.041x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.207x ➖, 0↑ 3↓)
datafusion / parquet (1.028x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.893x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.039x ➖, 0↑ 1↓)
duckdb / parquet (0.975x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.021x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.010x ➖, 0↑ 0↓)
duckdb / parquet (1.006x ➖, 0↑ 0↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.949x ➖ How to read Verdict and Engines
unknown / unknown (1.005x ➖, 3↑ 1↓)
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.992x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.997x ➖, 0↑ 0↓)
datafusion / parquet (0.999x ➖, 0↑ 0↓)
datafusion / arrow (0.975x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.999x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.993x ➖, 0↑ 0↓)
duckdb / parquet (1.003x ➖, 0↑ 0↓)
duckdb / duckdb (0.989x ➖, 0↑ 0↓)
File Size Changes (27 files changed, +0.0% overall, 13↑ 14↓)
Totals:
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.015x ➖, 0↑ 3↓)
datafusion / parquet (1.003x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.005x ➖, 1↑ 1↓)
duckdb / parquet (0.998x ➖, 1↑ 0↓)
duckdb / duckdb (1.005x ➖, 0↑ 0↓)
File Size Changes (104 files changed, +0.0% overall, 54↑ 50↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.941x ➖, 2↑ 1↓)
datafusion / vortex-compact (0.977x ➖, 0↑ 2↓)
datafusion / parquet (1.357x ❌, 1↑ 13↓)
duckdb / vortex-file-compressed (0.910x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.902x ➖, 0↑ 0↓)
duckdb / parquet (0.925x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.005x ➖ How to read Verdict and Engines
unknown / unknown (0.998x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.024x ➖, 0↑ 0↓)
datafusion / parquet (0.960x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.011x ➖, 0↑ 0↓)
duckdb / parquet (1.000x ➖, 0↑ 0↓)
duckdb / duckdb (0.977x ➖, 0↑ 0↓)
File Size Changes (4 files changed, -0.0% overall, 1↑ 3↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.030x ➖, 0↑ 2↓)
datafusion / vortex-compact (0.936x ➖, 0↑ 0↓)
datafusion / parquet (1.093x ➖, 0↑ 3↓)
duckdb / vortex-file-compressed (0.867x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.902x ➖, 0↑ 0↓)
duckdb / parquet (0.932x ➖, 0↑ 1↓)
|
joseph-isaacs
added
the
action/benchmark
…xecute-parent Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # vortex-array/src/executor.rs
`execute_until` and the single-step `Executable::execute` looked up the `ArrayKernels` session variable with `session.get`, which panics when the variable is absent. Sessions built without registering `ArrayKernels` (such as the `run_end_take` benchmark's `VortexSession::empty()`) then panicked during execution. Fall back to an empty `ArrayKernels` registry when the variable is not present, matching the optimizer's `get_opt` contract. The registry is consulted first and then each child's static `execute_parent` method, so built-in kernels still fire under an empty registry. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #8445 we need to use execute_parent kernels for in
execute_until.This PR does that change