Skip to content

Fix integer overflow in BitBufferMut::truncate and append_n #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksj1230 wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −1
Open

Fix integer overflow in BitBufferMut::truncate and append_n #8474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vortex-buffer/src/bit/buf_mut.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,8 @@ impl BitBufferMut {
if len > self.len {
return;
}


assert!(self.offset <= usize::MAX - len, "Truncate on BitBufferMut overflowed");
let end_bit = self.offset + len;
let new_len_bytes = end_bit.div_ceil(8);
self.buffer.truncate(new_len_bytes);
Expand Down Expand Up @@ -442,6 +443,8 @@ impl BitBufferMut {
return;
}

assert!(self.offset.checked_add(self.len).and_then(|v| v.checked_add(n)).is_some(),
"Append on BitBufferMut overflowed");
let end_bit_pos = self.offset + self.len + n;
let required_bytes = end_bit_pos.div_ceil(8);

Expand Down