bench: warm ArrayKernels before the bench loop#8479
Open
joseph-isaacs wants to merge 1 commit into
Open
Conversation
Add a test_harness-only `WarmKernelsExt` trait whose `warm_kernels` calls `get::<ArrayKernels>()`, and invoke it before `divan::main()` in the benchmarks so the one-time session-variable insertion happens during setup rather than inside the first measured iteration (which matters under CodSpeed's instruction-count simulation). Benches gated behind `#[cfg(not(codspeed))]` are CodSpeed-excluded and left unchanged. The two `vortex`-crate benches warm via a direct `get::<ArrayKernels>()` because they do not enable the `_test-harness` feature needed to reach the trait. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FtbtDsKWsbX6eEhCEoqPWD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test_harness-only
WarmKernelsExttrait whosewarm_kernelscallsget::<ArrayKernels>(), and invoke it beforedivan::main()in thebenchmarks so the one-time session-variable insertion happens during setup
rather than inside the first measured iteration (which matters under
CodSpeed's instruction-count simulation).
Benches gated behind
#[cfg(not(codspeed))]are CodSpeed-excluded and leftunchanged. The two
vortex-crate benches warm via a directget::<ArrayKernels>()because they do not enable the_test-harnessfeature needed to reach the trait.
Signed-off-by: Joe Isaacs joe.isaacs@live.co.uk
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FtbtDsKWsbX6eEhCEoqPWD