Minimize alignment noise in bitbuffer benchmarks#8487
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
161.8 µs | 198.6 µs | -18.54% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
178 µs | 214.7 µs | -17.11% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
273.7 µs | 308.4 µs | -11.25% |
| ⚡ | Simulation | take_10k_random |
255.7 µs | 197.8 µs | +29.23% |
| ⚡ | Simulation | take_10k_contiguous |
276.2 µs | 218.3 µs | +26.54% |
| ⚡ | Simulation | patched_take_10k_contiguous_patches |
290.9 µs | 232.3 µs | +25.21% |
| ⚡ | Simulation | patched_take_10k_random |
302.9 µs | 244.2 µs | +24.01% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
214.3 µs | 177.8 µs | +20.54% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
427.8 ns | 368.9 ns | +15.96% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 214.7 ns | +13.84% |
| ⚡ | Simulation | true_count_arrow_buffer[128] |
784.7 ns | 697.2 ns | +12.55% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275 ns | +10.81% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/aligned-benchmarks (77fab70) with develop (ad46b6c)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
Why do you try the default alignment of all buffers |
Summary
I'm trying to hunt down some of the noise in our benchmarks. This PR makes the bitbuffer benchmarks use a fixed alignment of 128 bytes.