Skip to content

Minimize alignment noise in bitbuffer benchmarks#8487

Open
AdamGS wants to merge 1 commit into
developfrom
adamg/aligned-benchmarks
Open

Minimize alignment noise in bitbuffer benchmarks#8487
AdamGS wants to merge 1 commit into
developfrom
adamg/aligned-benchmarks

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

I'm trying to hunt down some of the noise in our benchmarks. This PR makes the bitbuffer benchmarks use a fixed alignment of 128 bytes.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team, 0ax1 and robert3005 June 18, 2026 09:51
@AdamGS AdamGS added the changelog/chore A trivial change label Jun 18, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 9 improved benchmarks
❌ 3 regressed benchmarks
✅ 1569 untouched benchmarks
⏩ 3 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.8 µs 198.6 µs -18.54%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 178 µs 214.7 µs -17.11%
Simulation chunked_varbinview_canonical_into[(100, 100)] 273.7 µs 308.4 µs -11.25%
Simulation take_10k_random 255.7 µs 197.8 µs +29.23%
Simulation take_10k_contiguous 276.2 µs 218.3 µs +26.54%
Simulation patched_take_10k_contiguous_patches 290.9 µs 232.3 µs +25.21%
Simulation patched_take_10k_random 302.9 µs 244.2 µs +24.01%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 214.3 µs 177.8 µs +20.54%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 368.9 ns +15.96%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 214.7 ns +13.84%
Simulation true_count_arrow_buffer[128] 784.7 ns 697.2 ns +12.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275 ns +10.81%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/aligned-benchmarks (77fab70) with develop (ad46b6c)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread vortex-buffer/benches/vortex_bitbuffer.rs
@joseph-isaacs

Copy link
Copy Markdown
Contributor

Why do you try the default alignment of all buffers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants