Skip to content

fix for frame_deconvolution#724

Merged
VChristiaens merged 3 commits into
vortex-exoplanet:masterfrom
IainHammond:master
Jul 7, 2026
Merged

fix for frame_deconvolution#724
VChristiaens merged 3 commits into
vortex-exoplanet:masterfrom
IainHammond:master

Conversation

@IainHammond

@IainHammond IainHammond commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The best time to submit a pull request is before a new release; the second best time is right after.

A colleague at MPIA wanted to use the frame_deconvolution function in VIP but found it broken. I think it's been a while since it got some love. This was a matter of updating the num_iter variable which got renamed a long time ago in skimage, and also opening up the clip parameter. Hopefully everything is clean and documented nicely now.

Enjoy!

@codecov-commenter

codecov-commenter commented Jul 6, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.23%. Comparing base (67137a0) to head (510e7f3).
⚠️ Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
src/vip_hci/var/filters.py 12.50% 7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   50.32%   50.23%   -0.10%     
==========================================
  Files          88       88              
  Lines       17058    17089      +31     
==========================================
- Hits         8585     8584       -1     
- Misses       8473     8505      +32     
Flag Coverage Δ
no_objects 49.05% <12.50%> (?)
objects 60.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VChristiaens
VChristiaens merged commit f487abb into vortex-exoplanet:master Jul 7, 2026
18 checks passed
@VChristiaens

Copy link
Copy Markdown
Contributor

Thanks @IainHammond !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants