fix(flow): handle terminal actions for unloaded flows#376
Open
vchaplygim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Problem
Flows can exist in the database but be absent from the in-memory flow map when worker loading fails at startup. One reproducible case is a flow whose saved provider name no longer exists after the provider was renamed or deleted.
Before this change, terminal actions such as
finishFlow,stopFlow, RESTPUT /flows/{id}withfinish/stop, and GraphQLdeleteFlowdepended on the in-memory worker path. If the worker was not loaded, these actions returnedflow not foundor a generic internal error, leaving the flow stuck and its recorded container orphaned.Solution
This PR adds a DB-backed fallback in the flow controller for unloaded flows:
FinishFlownow verifies the DB row exists, removes recorded containers, marks the flowfinished, publishesFlowUpdated, and returns success when the worker is missing.StopFlownow verifies the DB row exists, removes recorded running/starting containers, marks active unloaded flowswaiting, publishesFlowUpdated, and returns success.stop/finishactions now call controller methods directly instead of requiringGetFlowfirst.deleteFlownow routes through controllerFinishFlowbefore deleting the DB row, closing the same cleanup gap.Closes #360
Type of Change
Areas Affected
Testing and Verification
Test Configuration