Fix SSH config Include path handling#288
Conversation
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.
Powered by Oz
|
Linked this PR to the same-repo tracking issue #282 as required by Oz. I tried to add Once a maintainer marks #282 This PR also addresses the original Warp issue warpdotdev/warp#9417 and supersedes the closed #280 by avoiding awk backslash parsing and tolerating unreadable Include paths. |
Summary
cygpath -uwhen available, with a/c/...fallback for Git Bash/MSYS-style shellsCloses #282.
Fixes warpdotdev/warp#9417.
Supersedes the closed #280 with two additional safeguards: the generator no longer uses awk for Include parsing, and unreadable Include paths no longer make the generator command fail.
Testing
cargo test -p warp-command-signatures ssh_config_command_ -- --nocapturecargo fmt --checkcargo test -p warp-command-signaturescargo clippy -p warp-command-signatures --all-targets -- -D warningscargo testcargo clippy --workspace --all-targets -- -D warningsgit diff --checkNotes