Skip to content

Fix SSH config Include path handling#288

Open
SkyNotSilent wants to merge 1 commit into
warpdotdev:mainfrom
SkyNotSilent:codex/fix-9417-ssh-include-windows-path
Open

Fix SSH config Include path handling#288
SkyNotSilent wants to merge 1 commit into
warpdotdev:mainfrom
SkyNotSilent:codex/fix-9417-ssh-include-windows-path

Conversation

@SkyNotSilent

@SkyNotSilent SkyNotSilent commented Jun 23, 2026

Copy link
Copy Markdown

Summary

  • preserve backslashes when reading SSH config Include directives instead of using awk field parsing
  • resolve Windows drive-letter Include paths through cygpath -u when available, with a /c/... fallback for Git Bash/MSYS-style shells
  • tolerate missing or unreadable Include files so other SSH hosts still produce completions

Closes #282.
Fixes warpdotdev/warp#9417.
Supersedes the closed #280 with two additional safeguards: the generator no longer uses awk for Include parsing, and unreadable Include paths no longer make the generator command fail.

Testing

  • cargo test -p warp-command-signatures ssh_config_command_ -- --nocapture
  • cargo fmt --check
  • cargo test -p warp-command-signatures
  • cargo clippy -p warp-command-signatures --all-targets -- -D warnings
  • cargo test
  • cargo clippy --workspace --all-targets -- -D warnings
  • git diff --check

Notes

  • This is generator-only command-signatures work; no Warp GUI screenshot is needed.

@cla-bot cla-bot Bot added the cla-signed label Jun 23, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 23, 2026

Copy link
Copy Markdown

@SkyNotSilent

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkyNotSilent

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

Powered by Oz

@SkyNotSilent

Copy link
Copy Markdown
Author

Linked this PR to the same-repo tracking issue #282 as required by Oz. I tried to add ready-to-implement to #282, but external contributors do not have label permissions.

Once a maintainer marks #282 ready-to-implement, I can comment /oz-review to re-trigger review.

This PR also addresses the original Warp issue warpdotdev/warp#9417 and supersedes the closed #280 by avoiding awk backslash parsing and tolerating unreadable Include paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH host completion drops hosts when ~/.ssh/config uses a Windows drive-letter Include path SSH config Include with Windows ssh.exe Git Bash

1 participant