Skip to content

feat: add file path link setting#12891

Open
davidrobertson wants to merge 1 commit into
warpdotdev:masterfrom
davidrobertson:davidrobertson/disable-file-hover-links
Open

feat: add file path link setting#12891
davidrobertson wants to merge 1 commit into
warpdotdev:masterfrom
davidrobertson:davidrobertson/disable-file-hover-links

Conversation

@davidrobertson

Copy link
Copy Markdown

Description

Adds a general.file_links setting that lets users disable file and directory path linkification in terminal output while keeping regular URL links enabled.

The setting is exposed in Features as "Link file paths in terminal output" and is available through the command palette enable/disable toggle flow.

Linked Issue

Closes #12890

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • I have manually tested my changes locally with ./script/run

Manual testing performed locally from this branch: toggling off "Link file paths in terminal output" stops file and directory paths in terminal output from receiving hover link styling, while URL links continue to work.

Automated checks:

  • ./script/format --check
  • cargo fmt --all -- --check
  • git diff --check

cargo check -p warp --lib was attempted. It progressed past protobuf after installing protobuf, then stopped in crates/warpui/build.rs because this local Xcode install is missing the Metal Toolchain (xcodebuild -downloadComponent MetalToolchain).

Screenshots / Videos

Not attached.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-IMPROVEMENT: Add a setting to disable file path links in terminal output.

@cla-bot

cla-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @davidrobertson on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@oz-for-oss

oz-for-oss Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@davidrobertson

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #12890, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 22, 2026

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidrobertson

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #12890, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@davidrobertson

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Jun 22, 2026
@cla-bot

cla-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setting to disable file path links in terminal output

1 participant