feat: add file path link setting#12891
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @davidrobertson on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
Every PR must be linked to a same-repo issue before Oz can review it. This PR is linked to #12890, but no linked issue is marked See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
This PR is linked to #12890, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Description
Adds a
general.file_linkssetting that lets users disable file and directory path linkification in terminal output while keeping regular URL links enabled.The setting is exposed in Features as "Link file paths in terminal output" and is available through the command palette enable/disable toggle flow.
Linked Issue
Closes #12890
ready-to-specorready-to-implement.Testing
./script/runManual testing performed locally from this branch: toggling off "Link file paths in terminal output" stops file and directory paths in terminal output from receiving hover link styling, while URL links continue to work.
Automated checks:
./script/format --checkcargo fmt --all -- --checkgit diff --checkcargo check -p warp --libwas attempted. It progressed past protobuf after installingprotobuf, then stopped incrates/warpui/build.rsbecause this local Xcode install is missing the Metal Toolchain (xcodebuild -downloadComponent MetalToolchain).Screenshots / Videos
Not attached.
Agent Mode
CHANGELOG-IMPROVEMENT: Add a setting to disable file path links in terminal output.