Center vertical tabs title search by SkyNotSilent · Pull Request #12899 · warpdotdev/warp

SkyNotSilent · 2026-06-22T07:40:41Z

Fixes #12217

Summary

Center the vertical-tabs title search as an overlay relative to the full title bar/window width
Keep left toolbar controls and right-side controls in the base title-bar row with their existing padding
Hide the centered title search when the window is narrow or cached left/right control bounds would collide with the centered search slot
Preserve the existing hide_title_bar_search_bar_in_vertical_tabs setting

Visual Evidence

Normal width: title search is centered in the full title bar, independent of left/right padding.

Narrow width: title search is hidden so it does not overlap toolbar controls.

Testing

cargo fmt --check
./script/format --check
git diff --check
cargo check -p warp
WARP_INTEGRATION_TEST_ARTIFACTS_DIR=/tmp/warp-pr-12899-centered-evidence-v3 WARPUI_USE_REAL_DISPLAY_IN_INTEGRATION_TESTS=1 cargo run -p integration --bin integration -- test_vertical_tabs_title_search_visual_evidence

oz-for-oss · 2026-06-22T07:41:01Z

@SkyNotSilent

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR changes the vertical-tabs title bar so the title search field renders as a centered overlay while preserving the hide-title-bar-search-bar setting. No approved spec context was provided, and the security pass did not identify security concerns.

Concerns

This is a user-facing layout change, but the attached PR description does not include screenshots or a screen recording demonstrating the centered search field end to end. Repository review guidance requires visual evidence for UI-impacting changes before merge.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-06-22T07:46:25Z

+                let mut stack = Stack::new();
+                stack.add_child(tab_bar);
+                stack.add_positioned_overlay_child(
+                    Container::new(self.render_title_bar_search_bar(appearance))


⚠️ [IMPORTANT] For this user-facing title-bar layout change, please include screenshots or a screen recording demonstrating it working end to end.

SkyNotSilent · 2026-06-23T06:46:55Z

Added visual evidence to the PR description.

Verification run:

WARP_INTEGRATION_TEST_ARTIFACTS_DIR=/tmp/warp-pr-12899-evidence WARPUI_USE_REAL_DISPLAY_IN_INTEGRATION_TESTS=1 cargo run -p integration --bin integration -- test_vertical_tabs_title_search_visual_evidence

The screenshot shows vertical tabs enabled and the title search field centered in the top title bar.

SkyNotSilent · 2026-06-23T06:46:57Z

/oz-review

oz-for-oss · 2026-06-23T06:47:16Z

@SkyNotSilent

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR changes the vertical-tabs title bar so the search field is rendered as a centered overlay while the left toolbar and right controls remain in the base row. The attached visual evidence covers the intended centered state, and there is no approved spec context to compare against.

Concerns

The new overlay no longer participates in the flex/shrink layout, so the fixed-width search control can overlap toolbar controls in narrow windows or with wider/custom toolbar configurations.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-06-23T06:51:24Z

+                let mut stack = Stack::new();
+                stack.add_child(tab_bar);
+                stack.add_positioned_overlay_child(
+                    Container::new(self.render_title_bar_search_bar(appearance))


⚠️ [IMPORTANT] The search bar is now a fixed-width overlay instead of a flex/shrink child, so on narrow windows or with extra toolbar items it can draw over and receive clicks above the left/right controls. Please keep the centered overlay constrained to the available gap, or shrink/hide it when there is not enough space.

SkyNotSilent · 2026-06-23T07:03:49Z

Updated to address the latest overlap concern.

Changes:

Added saved-position bounds for the vertical-tabs title-bar left and right control groups.
The centered title search overlay now renders only when the centered search bounds do not collide with those saved control bounds.
The overlay also hides below a conservative narrow-window width threshold, preserving toolbar controls instead of overlapping them.

Verified:

cargo fmt --check
./script/format --check
git diff --check
cargo check -p warp
WARP_INTEGRATION_TEST_ARTIFACTS_DIR=/tmp/warp-pr-12899-overlap-evidence WARPUI_USE_REAL_DISPLAY_IN_INTEGRATION_TESTS=1 cargo run -p integration --bin integration -- test_vertical_tabs_title_search_visual_evidence

I added updated visual evidence to the PR description for both normal-width centered rendering and the narrow-width hidden state.

SkyNotSilent · 2026-06-23T07:03:52Z

/oz-review

oz-for-oss · 2026-06-23T07:04:12Z

@SkyNotSilent

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR moves the vertical-tabs title search field into a centered overlay and hides it when cached left/right control bounds would collide. The PR includes visual evidence, and no approved spec context was provided.

Concerns

The overlay anchor still uses the padded tab-bar content area, so platforms/configurations with asymmetric title-bar padding can keep the search field offset from the actual window/title-bar center.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-06-23T07:07:24Z

+                        .with_padding_left(TITLE_BAR_SEARCH_BAR_SLOT_PADDING)
+                        .with_padding_right(TITLE_BAR_SEARCH_BAR_SLOT_PADDING)
+                        .finish(),
+                    OffsetPositioning::offset_from_parent(


⚠️ [IMPORTANT] This overlay is still anchored to the stack parent, but the stack is rendered inside Container::with_padding_left(left_padding)/right padding. On macOS left_padding includes traffic-light space, so ParentAnchor::Center lands right of the actual window/title-bar center while the collision math above uses window_bounds; anchor against an unpadded/full-window rect or compensate for the padding so #12217 is actually fixed.

SkyNotSilent · 2026-06-23T07:43:01Z

/oz-review

SkyNotSilent · 2026-06-23T07:43:01Z

Updated to address the asymmetric-padding centering concern.

Changes:

The base title-bar row now owns the existing left/right padding for toolbar controls.
The centered search overlay is layered by an outer title-bar stack, so its center anchor is the full title bar/window width rather than the padded controls row.
The narrow/collision guards remain in place, so the search hides instead of overlapping controls.

Verified:

cargo fmt --check
./script/format --check
git diff --check
cargo check -p warp
WARP_INTEGRATION_TEST_ARTIFACTS_DIR=/tmp/warp-pr-12899-centered-evidence-v3 WARPUI_USE_REAL_DISPLAY_IN_INTEGRATION_TESTS=1 cargo run -p integration --bin integration -- test_vertical_tabs_title_search_visual_evidence

The PR description has updated screenshots for both the full-width centered state and the narrow-width hidden state.

oz-for-oss · 2026-06-23T07:43:21Z

@SkyNotSilent

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @johnturcoo.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

oz-for-oss

Overview

This PR updates the vertical-tabs title bar so the command-palette search affordance is rendered as a centered overlay relative to the title bar while preserving the left and right control groups in their existing row. It also hides the centered search affordance when the window is too narrow or when cached control bounds would collide with the centered slot.

Concerns

No blocking concerns found.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

cla-bot Bot added the cla-signed label Jun 22, 2026

github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 22, 2026

oz-for-oss Bot previously requested changes Jun 22, 2026

View reviewed changes

oz-for-oss Bot previously requested changes Jun 23, 2026

View reviewed changes

SkyNotSilent force-pushed the SkyNotSilent/fix-12217-center-title-search branch from e7715fe to 2c3e40c Compare June 23, 2026 07:03

oz-for-oss Bot previously requested changes Jun 23, 2026

View reviewed changes

Center vertical tabs title search

738bec4

SkyNotSilent force-pushed the SkyNotSilent/fix-12217-center-title-search branch from 2c3e40c to 738bec4 Compare June 23, 2026 07:42

oz-for-oss Bot reviewed Jun 23, 2026

View reviewed changes

oz-for-oss Bot requested a review from johnturcoo June 23, 2026 07:46

Conversation

SkyNotSilent commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Visual Evidence

Testing

Uh oh!

oz-for-oss Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

SkyNotSilent commented Jun 23, 2026

Uh oh!

SkyNotSilent commented Jun 23, 2026

Uh oh!

oz-for-oss Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

SkyNotSilent commented Jun 23, 2026

Uh oh!

SkyNotSilent commented Jun 23, 2026

Uh oh!

oz-for-oss Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

SkyNotSilent commented Jun 23, 2026

Uh oh!

SkyNotSilent commented Jun 23, 2026

Uh oh!

oz-for-oss Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

SkyNotSilent commented Jun 22, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 22, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 23, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 23, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 23, 2026 •

edited

Loading