[gh-8226] Spec: open dir in external editor from tab + file tree menus#12901
[gh-8226] Spec: open dir in external editor from tab + file tree menus#129010xBB2B wants to merge 1 commit into
Conversation
… tree menus Adds PRODUCT.md and TECH.md for a feature-flagged "Open with <Editor>" menu item on two existing right-click context menus: - session tab (horizontal and vertical tab bars) - file-tree directory header The label is data-driven from the user's existing `code.editor.open_file_editor` setting; no editor is hardcoded. The Warp Drive workspace picker is explicitly out of scope (cloud entity, no local cwd). Remote/SSH paths and the click-on-output entry point from the original warpdotdev#8226 ask are deferred. Refs warpdotdev#8226.
|
Every PR must be linked to a same-repo issue before Oz can review it. Next step: open or find a same-repo issue describing this change, then link it to this PR by adding See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
Summary
Add
PRODUCT.mdandTECH.mdfor a feature-flagged "Open with " item on two existing right-click context menus — session tabs and file-tree directory headers. The menu label is rendered from the user's existingcode.editor.open_file_editorsetting; no editor is hardcoded. No code changes in this PR.Motivation
Issue #8226 asks for a way to open a directory in
$EDITORfrom Warp. Today's "Open in editor" plumbing supports files only; there is no fast path from "this tab represents a project" or "this is a folder in the file tree" to "open this folder in my editor." This spec defines one of three complementary UX entry points discussed on the issue (the other two — click-on-output and prompt-area chip — remain out of scope and are tracked separately).What's changed
specs/gh-8226-open-with-editor/PRODUCT.md— Summary / Problem / Non-goals / Behavior (8 numbered points) / Validation.specs/gh-8226-open-with-editor/TECH.md— Anchors in current code (with file:line refs toexternal_editor/mod.rs,tab.rs,code/file_tree/view.rs), proposed changes (newopen_directory_in_external_editor+ per-platform impls, newFeatureFlag::OpenDirectoryInExternalEditor, two new action variants, shared label helper), testing notes, rollout.Out of scope
app/src/drive/index.rs render_workspace_picker) — cloud entities have no local cwd.Validation
Documentation-only PR. The validation cases that the implementation PR will exercise are listed in
PRODUCT.md§ Validation:EditorChoice::Warpomits the item.EditorChoice::EnvEditorwith empty\$EDITORomits the item.master.Related issues