Skip to content

[gh-8226] Spec: open dir in external editor from tab + file tree menus#12901

Open
0xBB2B wants to merge 1 commit into
warpdotdev:masterfrom
0xBB2B:bb/open-with-editor-menu
Open

[gh-8226] Spec: open dir in external editor from tab + file tree menus#12901
0xBB2B wants to merge 1 commit into
warpdotdev:masterfrom
0xBB2B:bb/open-with-editor-menu

Conversation

@0xBB2B

@0xBB2B 0xBB2B commented Jun 22, 2026

Copy link
Copy Markdown

Summary

Add PRODUCT.md and TECH.md for a feature-flagged "Open with " item on two existing right-click context menus — session tabs and file-tree directory headers. The menu label is rendered from the user's existing code.editor.open_file_editor setting; no editor is hardcoded. No code changes in this PR.

Motivation

Issue #8226 asks for a way to open a directory in $EDITOR from Warp. Today's "Open in editor" plumbing supports files only; there is no fast path from "this tab represents a project" or "this is a folder in the file tree" to "open this folder in my editor." This spec defines one of three complementary UX entry points discussed on the issue (the other two — click-on-output and prompt-area chip — remain out of scope and are tracked separately).

What's changed

  • specs/gh-8226-open-with-editor/PRODUCT.md — Summary / Problem / Non-goals / Behavior (8 numbered points) / Validation.
  • specs/gh-8226-open-with-editor/TECH.md — Anchors in current code (with file:line refs to external_editor/mod.rs, tab.rs, code/file_tree/view.rs), proposed changes (new open_directory_in_external_editor + per-platform impls, new FeatureFlag::OpenDirectoryInExternalEditor, two new action variants, shared label helper), testing notes, rollout.

Out of scope

  • Hijacking clicks on directory paths printed inside terminal output (the original ask in this issue).
  • Prompt-area "Open in IDE" chip (@ATERCATES's prototype on a fork).
  • Warp Drive workspace switcher (app/src/drive/index.rs render_workspace_picker) — cloud entities have no local cwd.
  • SSH / remote terminal paths.
  • Line/column positioning (directories have no caret).

Validation

Documentation-only PR. The validation cases that the implementation PR will exercise are listed in PRODUCT.md § Validation:

  • Editor setting changes update the label on next menu open.
  • EditorChoice::Warp omits the item.
  • EditorChoice::EnvEditor with empty \$EDITOR omits the item.
  • File-tree remote entries omit the item (matches existing "Reveal in Finder" treatment).
  • Feature flag off → both menus are byte-for-byte unchanged from current master.

Related issues

… tree menus

Adds PRODUCT.md and TECH.md for a feature-flagged "Open with <Editor>"
menu item on two existing right-click context menus:

- session tab (horizontal and vertical tab bars)
- file-tree directory header

The label is data-driven from the user's existing
`code.editor.open_file_editor` setting; no editor is hardcoded. The
Warp Drive workspace picker is explicitly out of scope (cloud entity,
no local cwd). Remote/SSH paths and the click-on-output entry point
from the original warpdotdev#8226 ask are deferred.

Refs warpdotdev#8226.
@cla-bot cla-bot Bot added the cla-signed label Jun 22, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@0xBB2B

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 22, 2026

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xBB2B

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-spec when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant