Keep workspace shortcuts active when terminal pane is focused

[SkyNotSilent]

Summary

• make Workspace_TextOpen depend on the focused pane being a code pane instead of any code pane existing in the active tab
• add a regression test for split-pane tabs where a code pane exists but focus returns to a terminal pane

Closes #8187.

Testing

• cargo fmt --check
• git diff --check
• ./script/format --check
• PATH="/tmp/warp-fake-xcrun:$PATH" cargo test -p warp keymap_context_marks_text_open_only_for_focused_code_pane
• PATH="/tmp/warp-fake-xcrun:$PATH" cargo check -p warp

Note: /tmp/warp-fake-xcrun only bypasses the missing local Xcode Metal shader compiler in this environment.

[oz-for-oss]

@SkyNotSilent

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR changes Workspace_TextOpen so it is set only when the focused pane is a code pane, and adds a regression test for split-pane focus returning to a terminal pane.

Concerns

• This is a user-facing keybinding behavior change, but the PR description does not include screenshots or a screen recording demonstrating the behavior end to end. For this user-facing change, please include screenshots or a short recording showing workspace shortcuts remain active when a terminal pane is focused and text-editor suppression returns when the code pane is focused.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz