Fix Codex plugin installation#12919
Conversation
Ensure CODEX_HOME exists before plugin commands. Restore plugin add after marketplace add. Restore config.toml enabled detection. Log command output on failures. Co-Authored-By: Oz <oz-agent@warp.dev>
liliwilson
force-pushed
the
lili/fix-codex-plugin-install
branch
from
bf13515 to
be6895c
Compare
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR fixes Codex plugin auto-install for fresh per-workspace CODEX_HOME directories, restores the explicit plugin add command, and switches installed/update detection back to Codex config/cache state.
Concerns
- The new install paths always run
codex plugin marketplace add warpdotdev/codex-warp, which drops the previous guard that avoided mutating a configured non-Git/localcodex-warpmarketplace override. - The PR changes user-facing install/update instructions but does not include screenshots or a recording of the affected UI/flow.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Ensure CODEX_HOME exists before plugin commands. Restore plugin add after marketplace add. Restore config.toml enabled detection. Preserve non-Git codex-warp marketplace overrides. Co-Authored-By: Oz <oz-agent@warp.dev>
liliwilson
force-pushed
the
lili/fix-codex-plugin-install
branch
from
be6895c to
5cfa012
Compare
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the Codex plugin manager to create the resolved CODEX_HOME before plugin commands, restore codex plugin add during install/update flows, detect enabled plugin state from config.toml, and read cached plugin versions.
Concerns
- The changed Codex plugin install/update instructions and setup behavior are user-facing, but the PR description does not include screenshots or a screen recording demonstrating the updated flow end to end. Per repository guidance, visual evidence is required for user-facing changes.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| post_install_notes: &[ | ||
| "Restart Codex to activate the plugin.", | ||
| "No separate plugin add/install command is required in current Codex versions.", | ||
| subtitle: "Run the following commands, then restart Codex.", |
There was a problem hiding this comment.
liliwilson
changed the title
2 participants
Description
Fixes the Codex plugin auto-install path so it works when
CODEX_HOMEis set to a per-workspace directory that does not yet exist.CODEX_HOMEdirectory before running anycodex plugincommand. (This is mainly relevant for self-hosted direct backend workers, where we setCODEX_HOMEto be different)codex plugin add <key>step after marketplace add, which was accidentally dropped in Auto-install Codex orchestration plugin for harness runs #11892.config.tomlenabled-state detection and cache-based version detection (also regressed in Auto-install Codex orchestration plugin for harness runs #11892).codex-warpmarketplace overrides: skip marketplace add/upgrade when the marketplace is configured as a local directory.Testing
Tested locally with the
oz-localscript.Agent Mode
Co-Authored-By: Oz oz-agent@warp.dev