Fix sanitizer attribute breakout via href/src charref decoding#40
Open
metsw24-max wants to merge 1 commit into
Open
Fix sanitizer attribute breakout via href/src charref decoding#40metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the downstream mitigation added in web2py PR #2599: web2py/web2py#2599
This patch fixes the issue at the source in yatl’s sanitizer implementation.
HTMLParserdecodes character references before attribute reconstruction.href,src, andbackgroundvalues were not consistently routed throughquoteattr(), which could allow crafted payloads to break out of the attribute context after parser normalization.This change applies the same escaping path already used for other attributes and documents the parser-decoding behavior with an inline comment.
Changes
Route
href,src, andbackgroundthroughquoteattr()Add explanatory comment about
HTMLParsercharacter reference decodingAdd regression test:
test_sanitize_attribute_breakoutHTMLParserVerification
18/18)Why this belongs in yatl
The previous web2py-side mitigation addressed the symptom downstream. This patch fixes the sanitizer behavior directly in yatl so all consumers benefit from the corrected escaping behavior.