Restore center-crop to square for profile image resizing when target dimensions are square#3229
Open
Almee98 wants to merge 1 commit into
Open
Restore center-crop to square for profile image resizing when target dimensions are square#3229Almee98 wants to merge 1 commit into
Almee98 wants to merge 1 commit into
Conversation
…dimensions are square
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores square cropping for profile photo resizing when the target output size is square (e.g. 200×200, 48×48, 32×32). Rectangular source images are now center-cropped before resize instead of being fit with
ImageOps.contain, which preserved aspect ratio and produced non-square output files.Problem
Profile photos are displayed as squares in the UI, but non-square uploads (e.g. wide rectangular images) were not being converted to square resized versions. This regressed in PR #3052, which replaced the previous
crop_to_squarelogic withImageOps.containfor all non–Facebook-background images.Related history
crop_to_squareinresize_we_vote_master_image)