Preliminary changes for a Cordova iOS release#4852
Merged
Conversation
Removed login with Facebook (iOS) and FacebookInvitableFriends (for all), for which the implementation libraries had gone obsolete. Add Friends from your contacts (Apple) is limping along on deprecated libraries. Hopefully it will keep on working until an updated solution emerges.
Removed login with Facebook (iOS) and FacebookInvitableFriends (for all), for which the implementation libraries had gone obsolete. Add Friends from your contacts (Apple) is limping along on deprecated libraries. Hopefully it will keep on working until an updated solution emerges.
DaleMcGrew
approved these changes
Jul 1, 2026
DaleMcGrew
left a comment
DaleMcGrew
left a comment
Member
There was a problem hiding this comment.
Thank you @SailingSteve! 👍
|
|
||
| if (route) { | ||
| // OpenExternalWebSite was called for an internal route (ok, but not the way it is supposed to be used) | ||
| // console.log('---------- route: ', route); |
Member
There was a problem hiding this comment.
Hi @SailingSteve, is there a reason we couldn't also call this.sendExternalLinkInfoToGTM() before the historyPush as well?
| pathToUseToKeepHelping={pathToUseToKeepHelping} | ||
| photoLargeUrl={candidatePhotoLargeUrl} | ||
| politicalParty={politicalParty} | ||
| politicalParty={politicalParty.length ? politicalParty : 'Non-Partisan Primary'} |
Member
There was a problem hiding this comment.
Hi @SailingSteve we can't assume the lack of data for politicalParty means that it is either Non-Partisan or a Primary: politicalParty={politicalParty.length ? politicalParty : 'Non-Partisan Primary'}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed login with Facebook (for iOS) and FacebookInvitableFriends (for all), for which the implementation libraries had gone obsolete.
Add Friends from your contacts (Apple) is limping along on deprecated libraries. Hopefully it will keep on working until an updated solution emerges.