Skip to content

Landlock causes HTTPs permission issues #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OwenCochell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Landlock causes HTTPs permission issues #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions cmd/wireproxy/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,25 @@ func configFilePath() (string, bool) {
return "", false
}

func lock(stage string) {
// get the file paths for TLS cert and key from the config
func tlsFilePaths(routines []wireproxy.RoutineSpawner) []string {
var paths []string
for _, routine := range routines {
http, ok := routine.(*wireproxy.HTTPConfig)
if !ok {
continue
}
if http.CertFile != "" {
paths = append(paths, http.CertFile)
}
if http.KeyFile != "" {
paths = append(paths, http.KeyFile)
}
}
return paths
}

func lock(stage string, roFilles ...string) {
switch stage {
case "boot":
exePath := executablePath()
Expand All @@ -93,7 +111,11 @@ func lock(stage string) {
pledgeOrPanic("stdio inet dns")
// Linux
net.DefaultResolver.PreferGo = true // needed to lock down dependencies
panicIfError(landlock.V1.BestEffort().RestrictPaths(

// We need to define the static rules beforehand,
// so we can add the provided dynamic rules

rules := []landlock.Rule{
landlock.ROFiles("/etc/resolv.conf").IgnoreIfMissing(),
landlock.ROFiles("/dev/fd").IgnoreIfMissing(),
landlock.ROFiles("/dev/zero").IgnoreIfMissing(),
Expand All @@ -112,7 +134,16 @@ func lock(stage string) {
landlock.RWFiles("/dev/null").IgnoreIfMissing(),
landlock.RWFiles("/dev/full").IgnoreIfMissing(),
landlock.RWFiles("/proc/self/fd").IgnoreIfMissing(),
))
}

if len(roFilles) > 0 {
for _, file := range roFilles {
rules = append(rules, landlock.ROFiles(file).IgnoreIfMissing())
}
}

panicIfError(landlock.V1.BestEffort().RestrictPaths(rules...))

default:
panic("invalid stage")
}
Expand Down Expand Up @@ -246,7 +277,7 @@ func main() {
logLevel = device.LogLevelSilent
}

lock("ready")
lock("ready", tlsFilePaths(conf.Routines)...)

tun, err := wireproxy.StartWireguard(conf, logLevel)
if err != nil {
Expand Down