Skip to content

fix: eslint auto import type declaration#2297

Draft
PatrykKuniczak wants to merge 4 commits into
wxt-dev:mainfrom
PatrykKuniczak:fix/eslint-auto-import-type-declaration
Draft

fix: eslint auto import type declaration#2297
PatrykKuniczak wants to merge 4 commits into
wxt-dev:mainfrom
PatrykKuniczak:fix/eslint-auto-import-type-declaration

Conversation

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator

Overview

Fixed abandoned #1981

Blocked by #2296 #2295 (After those, i'll adjust code to version 10)

Manual Testing

Let's see if tests pass

@PatrykKuniczak PatrykKuniczak self-assigned this Apr 24, 2026
@netlify

netlify Bot commented Apr 24, 2026

Copy link
Copy Markdown

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 47b32ba
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a428c6f450cc8000861cd62
😎 Deploy Preview https://deploy-preview-2297--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Apr 24, 2026
@pkg-pr-new

pkg-pr-new Bot commented Apr 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2297

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2297

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2297

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2297

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2297

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2297

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2297

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2297

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2297

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2297

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2297

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2297

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2297

wxt

npm i https://pkg.pr.new/wxt@2297

commit: 47b32ba

@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.56%. Comparing base (fc269ed) to head (47b32ba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2297      +/-   ##
==========================================
+ Coverage   78.43%   78.56%   +0.12%     
==========================================
  Files         134      134              
  Lines        3914     3918       +4     
  Branches      888      888              
==========================================
+ Hits         3070     3078       +8     
+ Misses        753      751       -2     
+ Partials       91       89       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrykKuniczak PatrykKuniczak marked this pull request as draft April 24, 2026 13:41
@aklinker1

Copy link
Copy Markdown
Member

What does this PR do?

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator Author

@aklinker1 fixes issue with missing type import for eslint.config generated .d.ts file, when somebody using eslint.config.ts

@PatrykKuniczak

Copy link
Copy Markdown
Collaborator Author

@aklinker1 After #2295 #2296 i'll update this branch and add testst

@aklinker1

Copy link
Copy Markdown
Member

Seems like this could be merged as-is today.

@aklinker1 aklinker1 closed this Jun 28, 2026
@aklinker1

Copy link
Copy Markdown
Member

Woops, didn't mean to close

@aklinker1 aklinker1 reopened this Jun 28, 2026
@PatrykKuniczak PatrykKuniczak marked this pull request as ready for review June 29, 2026 15:17
@PatrykKuniczak

Copy link
Copy Markdown
Collaborator Author

@aklinker1 Yeah, it can go, i can adjust other related PRs, not necessary that one.

@PatrykKuniczak PatrykKuniczak enabled auto-merge (squash) June 29, 2026 15:18
@PatrykKuniczak PatrykKuniczak disabled auto-merge June 29, 2026 15:18
@PatrykKuniczak

PatrykKuniczak commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

@aklinker1 I know why that's draft.

I want to merge those 2 PRs and then add tests there.

Let's wait till both will be merged and then i'll update that branch and add those tests.

@PatrykKuniczak PatrykKuniczak marked this pull request as draft June 29, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants