feat: add storage metadata watchers#2445
Open
cookesan wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
the
pkg/storage
aklinker1
reviewed
Jun 29, 2026
|
|
||
| const getMetaValue = (properties: any) => | ||
| typeof properties === 'object' && !Array.isArray(properties) | ||
| properties != null && |
Member
There was a problem hiding this comment.
This a breaking change? We used to return null when meta was empty, but now we don't?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage.watchMetaanditem.watchMetafor listening to metadata changes without using the internal metadata key{}so watcher callbacks matchgetMetaTests
bun run --filter @wxt-dev/storage test index.test.tsbun run --filter @wxt-dev/storage checkbun run --filter @wxt-dev/storage buildbun run docs:buildbun run checkbunx prettier --check docs/storage.md packages/storage/src/index.ts packages/storage/src/__tests__/index.test.tsgit diff --checkFixes #1988