refactor: round 2 — modularize ncorr.cpp by algorithm (plan)#19
Draft
johnaoga wants to merge 1 commit into
Draft
refactor: round 2 — modularize ncorr.cpp by algorithm (plan)#19johnaoga wants to merge 1 commit into
johnaoga wants to merge 1 commit into
Conversation
Review of the stale ja/refactoring/1 branch against current main: ImageProcessor/VideoImporter and diagnostics were absorbed or superseded by the newversion (#12) and leveled logging (#18); the surviving ideas (seed-analysis extraction, exact-chain module, matlab_DIC_analysis dedup) are re-planned against today's code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second refactoring round, replacing the stale
ja/refactoring/1(#10) which forked before the newversion restructure (#12) and no longer applies tomain.This PR starts with the plan document (docs/refactoring_plan.md); implementation commits will follow on this branch.
Review of round 1
Image2D.h(in-memory API, factories).NCORR_ENABLE_DIAGNOSTICS→ leveled loggingncorr/log.h(feat: dependency-free leveled logging facility #18).Plan
ncorr_seed.{hpp,cpp}, ~300 ln from ncorr.cpp:4804–5083) and the exact MATLAB chain-composition path (ncorr_exact_chain.{hpp,cpp}, ~400 ln from ncorr.cpp:5409–5815), each with new unit-test seams.matlab_DIC_analysis_impl/exact_matlab_DIC_analysis_impl(~65% duplicated) behind a chain-composition strategy; document the public engine API surface used by CPPxDIC's adapter.Guardrails: pure-move commits, test suite green at every step, no behavior change.
Supersedes #10.
🤖 Generated with Claude Code