Skip to content

Fix year timespan divider#79

Draft
Mirochill wants to merge 1 commit into
xolox:masterfrom
Mirochill:fix-78-year-timespan-divider
Draft

Fix year timespan divider#79
Mirochill wants to merge 1 commit into
xolox:masterfrom
Mirochill:fix-78-year-timespan-divider

Conversation

@Mirochill
Copy link
Copy Markdown

Closes #78.

Summary

  • change the year timespan divider from 52 weeks to 365 days
  • update the format_timespan() example and tests to use the corrected year length
  • add parse_timespan() coverage for year units

Validation

  • git diff --check HEAD~1..HEAD
  • Not run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time unit for year is wrong. There are 365 or 366 days in a normal year, not 7 * 52 = 364

1 participant