match d_lyt_map_capture#328
Conversation
Report for SOUE01 (560ff18 - 21c7dac)📈 Matched code: 25.81% (+0.01%, +680 bytes) ✅ 5 new matches
📈 1 improvement in an unmatched item
|
robojumper
left a comment
robojumper
left a comment
There was a problem hiding this comment.
Please run any files you changed through clang-format.
When implementing functions that you had to manually map in objdiff, run tools/custom/apply_objdiff_mappings.py to make the names known to the rest of the tooling. Right now the PR report says "no changes", which is not right.
| out->z = z; | ||
| } | ||
|
|
||
| extern int fn_801B5970(MapRelated*, const GXTexObj*); |
There was a problem hiding this comment.
Please declare as a member function of MapRelated. C++ member functions typically implicitly take this as the first argument.
| float x = v.x; | ||
| out->y = y; | ||
| out->x = x; | ||
| out->z = z; |
There was a problem hiding this comment.
Try *out = ... or out->set(...) or out->copyFrom(...), the temps are almost certainly unnecessary.
| mStateMgr.executeState(); | ||
| } | ||
|
|
||
| void fn_8012D6D0(mVec3_c *ignored, mVec3_c *out) { |
There was a problem hiding this comment.
These might also be member functions of dLytMapCapture_c?
|
I did the changes, but now it doesn't build... I don't know what I did wrong... |
|
The function at 0x8012D670 is wrongly labelled in symbols.txt |
|
Okay now there is a regression, please undo the change at 0x80144690 in symbols.txt |
2 participants
Matching main/d/lyt/d_lyt_map_capture at 95%,
I forgot to remove the commented field in d_stage.h.