Migrate away from the deprecated onBackPressed#472
Open
ElCruncharino wants to merge 1 commit into
Open
Conversation
On Android 16+ predictive back is enabled by default for apps targeting API 36 and the deprecated onBackPressed override is no longer called, which broke the double-back-to-exit confirmation. The exit confirmation now lives in an OnBackPressedCallback that is only enabled when a back press would actually leave the app, so the system back animations keep working on every other screen. Closes LivingWithHippos#262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android 16 predictive back is enabled by default for apps targeting API 36 and the deprecated onBackPressed override stops being called, so the double back to exit confirmation was broken.
The exit confirmation now lives in an OnBackPressedCallback registered on the dispatcher. The callback is only enabled when pressing back would actually close the app (same destinations as before: user or authentication screen with no real back stack behind them). Everywhere else the system handles back natively, so the predictive back animations keep working. Also replaced the deprecated call in SettingsActivity.
Closes #262