[NFC] Remove quit() from fuzz_shell.js#8779
Closed
kripken wants to merge 1 commit into
Closed
Conversation
kripken
changed the title
aheejin
approved these changes
May 26, 2026
Member
Author
|
Hmm, actually this does not work by itself - I'll have to keep it in the larger PR I was trying to split it out of. It requires some fuzzer adjustments actually. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was called in an error condition.
quitdoes not exist in most JSshells, so this just throws. Fix it to throw a nicer error.
Also fix another error in an error path in python - there is no
proc.stderror, it isstderr.