Skip to content

[NFC] Remove quit() from fuzz_shell.js #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kripken wants to merge 1 commit into from
+2 −3
Closed

[NFC] Remove quit() from fuzz_shell.js #8779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/auto_update_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def update_example_tests():
subprocess.check_call(cmd)
print('run...', output_file)
proc = subprocess.run([output_file], capture_output=True)
assert proc.returncode == 0, [proc.returncode, proc.stderror, proc.stdout]
assert proc.returncode == 0, [proc.returncode, proc.stderr, proc.stdout]
actual = proc.stdout
with open(expected, 'wb') as o:
o.write(actual)
Expand Down
3 changes: 1 addition & 2 deletions scripts/fuzz_shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,8 +520,7 @@ function build(binary, isSecond) {
try {
instance = new WebAssembly.Instance(module, imports);
} catch (e) {
console.log('exception thrown: failed to instantiate module: ' + e);
quit();
throw new Error('exception thrown: failed to instantiate module: ' + e);
}

// Do not add the second instance's exports to the list, as that would be
Expand Down
Loading