Skip to content

CSA-467: Skip blank rows in CSV preprocessing and delta caching#2590

Merged
cmgrote merged 2 commits into
mainfrom
bala/csa-467
Jun 26, 2026
Merged

CSA-467: Skip blank rows in CSV preprocessing and delta caching#2590
cmgrote merged 2 commits into
mainfrom
bala/csa-467

Conversation

@bladata1990

Copy link
Copy Markdown
Collaborator

Summary

Guards against entirely-blank CSV rows (e.g. a trailing ,,,,, line) that otherwise produce assets with empty typeName/qualifiedName and later break delta calculation with Invalid asset identity: ::.

  • CSVReader.kt — skip writing rows where every field is blank to the preprocessed/.processed output.
  • FileBasedDelta.kt — skip caching identities with blank typeName/qualifiedName; log a warning instead of serializing a :: key.

Test plan

  • Verify CSV with trailing blank rows no longer fails delta calc

🤖 Generated with Claude Code

Signed-off-by: bladata1990 <balakrishnan.r@atlan.com>
@bladata1990 bladata1990 requested a review from cmgrote as a code owner June 26, 2026 06:31
@linear

linear Bot commented Jun 26, 2026

Copy link
Copy Markdown

CSA-467

@cmgrote cmgrote merged commit 9e7ce57 into main Jun 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants