Skip to content

CSA-467: Skip blank rows in CSV preprocessing and delta caching #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmgrote merged 2 commits into from
Jun 26, 2026
Merged

CSA-467: Skip blank rows in CSV preprocessing and delta caching #2590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fcf500
CSA-467
bladata1990 Jun 26, 2026
462e64f
Merge branch 'main' into bala/csa-467
bladata1990 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/serde/csv/CSVReader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,12 @@ class CSVReader
csv.writeHeader(outputHeaders ?: header)
preproc.stream().skip(1).forEach { r: CsvRecord ->
val transformed = csvPreprocessor.preprocessRow(r.fields, header, typeIdx, qualifiedNameIdx)
csv.writeRecord(transformed)
// Skip entirely-blank rows (e.g. a trailing ",,,,," line): writing these to the
// preprocessed/.processed output produces an asset with empty typeName and qualifiedName,
// which later fails delta calculation with "Invalid asset identity: ::". (CSA-467)
if (transformed.any { it.isNotBlank() }) {
csv.writeRecord(transformed)
}
}
preproc.close()
}
Expand Down
11 changes: 10 additions & 1 deletion package-toolkit/runtime/src/main/kotlin/com/atlan/pkg/util/FileBasedDelta.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,19 @@ class FileBasedDelta(
reader.stream().skip(1).forEach { r: CsvRecord ->
val values = r.fields
val assetIdentity = resolveAsset(values, header)
if (assetIdentity != null) {
// Guard against rows that resolve to a blank typeName and/or qualifiedName (e.g. a trailing
// ",,,,," line that slipped into a previously-written .processed file). Caching such an identity
// serializes its key as "::", which later fails deserialization with
// "Invalid asset identity: ::" while iterating the checksum cache. (CSA-467)
if (assetIdentity != null &&
assetIdentity.typeName.isNotBlank() &&
assetIdentity.qualifiedName.isNotBlank()
) {
val singleLine = r.fields.joinToString("§")
val checksum = Hashing.murmur3_128().hashString(singleLine, Charsets.UTF_8).toString()
cache.put(assetIdentity, checksum)
} else {
logger.warn { "Skipping row with blank typeName/qualifiedName in $filename: $values" }
}
}
}
Expand Down
Loading