Skip to content

feat: drop multitool#146

Open
AlexanderLanin wants to merge 1 commit into
eclipse-score:mainfrom
etas-contrib:drop_multi
Open

feat: drop multitool#146
AlexanderLanin wants to merge 1 commit into
eclipse-score:mainfrom
etas-contrib:drop_multi

Conversation

@AlexanderLanin

@AlexanderLanin AlexanderLanin commented Apr 9, 2026

Copy link
Copy Markdown
Member

We do not use multitool anymore, so we remove it from tooling. The goal is to remove old obsolete stuff from this repository step by step.

@hoe-jo hoe-jo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clarify If it is still used first

Comment thread format_checker/macros.bzl
Comment on lines -18 to -31
python = "@aspect_rules_lint//format:ruff",
rust = "@score_tooling//format_checker:rustfmt_with_policies",
starlark = "@buildifier_prebuilt//:buildifier",
yaml = "@aspect_rules_lint//format:yamlfmt",
visibility = ["//visibility:public"],
)

format_test(
name = check_name,
no_sandbox = True,
python = "@aspect_rules_lint//format:ruff",
rust = "@score_tooling//format_checker:rustfmt_with_policies",
starlark = "@buildifier_prebuilt//:buildifier",
yaml = "@aspect_rules_lint//format:yamlfmt",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are python and yaml formatters removed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have been moved to devcontainer 2 months ago. See eclipse-score/docs-as-code#614

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you meant to link this PR:
eclipse-score/devcontainer#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants