Skip to content

feat: drop multitool #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderLanin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: drop multitool #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 8 additions & 44 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

module(
name = "score_tooling",
version = "0.0.0",
compatibility_level = 1,
)
module(name = "score_tooling")

###############################################################################
# Core Dependencies
Expand All @@ -28,7 +24,7 @@ bazel_dep(name = "aspect_rules_lint", version = "1.5.3")
bazel_dep(name = "rules_shell", version = "0.5.0")
bazel_dep(name = "rules_java", version = "8.15.1")
bazel_dep(name = "rules_rust", version = "0.61.0")
bazel_dep(name = "rules_multitool", version = "1.9.0")
bazel_dep(name = "rules_multitool", version = "1.9.0", dev_dependency = True)
bazel_dep(name = "score_rust_policies", version = "0.0.2")
bazel_dep(name = "bazel_skylib", version = "1.7.1")
bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
Expand Down Expand Up @@ -151,51 +147,19 @@ pip.parse(
)
use_repo(pip, "pip_tooling")

###############################################################################
# Multitool Hub (for ruff, pyright, actionlint, etc.)
###############################################################################
multitool = use_extension("@rules_multitool//multitool:extension.bzl", "multitool")

#python_basics
multitool.hub(lockfile = "python_basics/multitool.lock.json")
use_repo(multitool, "multitool")

# Ruff Hub
multitool.hub(
hub_name = "ruff_hub",
lockfile = "tools/ruff.lock.json",
)
use_repo(multitool, "ruff_hub")

# Actionlint Hub
multitool.hub(
hub_name = "actionlint_hub",
lockfile = "tools/actionlint.lock.json",
)
use_repo(multitool, "actionlint_hub")

# Shellcheck Hub
multitool.hub(
hub_name = "shellcheck_hub",
lockfile = "tools/shellcheck.lock.json",
)
use_repo(multitool, "shellcheck_hub")

# YAMLfmt Hub
multitool.hub(
hub_name = "yamlfmt_hub",
lockfile = "tools/yamlfmt.lock.json",
)
use_repo(multitool, "yamlfmt_hub")

register_toolchains(
"//bazel/rules/rules_score:sphinx_default_toolchain",
)

###############################################################################
# Dev Dependencies (for testing)
###############################################################################
bazel_dep(name = "score_docs_as_code", version = "3.0.1", dev_dependency = True)
bazel_dep(name = "score_docs_as_code", dev_dependency = True)
git_override(
module_name = "score_docs_as_code",
remote = "https://github.com/eclipse-score/docs-as-code.git",
commit = "4a05a739e56fbc8bf41b8445f3ac2b84db85bdd8",
)

###############################################################################
# Dependencies for Manual Analysis
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ See the individual README files for detailed usage instructions and configuratio
| **format_checker** | Code formatting validation | [README](format_checker/README.md) |
| **python_basics** | Python development utilities and testing | [README](python_basics/README.md) |
| **starpls** | Starlark language server support | [README](starpls/README.md) |
| **tools** | Formatters & Linters | [README](tools/README.md) |
| **coverage** | Ferrocene Rust coverage workflow | [README](coverage/README.md) |

## Usage Examples
Expand Down
4 changes: 0 additions & 4 deletions format_checker/macros.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,16 @@ load("@aspect_rules_lint//format:defs.bzl", "format_multirun", "format_test")
def use_format_targets(fix_name = "format.fix", check_name = "format.check"):
format_multirun(
name = fix_name,
python = "@aspect_rules_lint//format:ruff",
rust = "@score_tooling//format_checker:rustfmt_with_policies",
starlark = "@buildifier_prebuilt//:buildifier",
yaml = "@aspect_rules_lint//format:yamlfmt",
visibility = ["//visibility:public"],
)

format_test(
name = check_name,
no_sandbox = True,
python = "@aspect_rules_lint//format:ruff",
rust = "@score_tooling//format_checker:rustfmt_with_policies",
starlark = "@buildifier_prebuilt//:buildifier",
yaml = "@aspect_rules_lint//format:yamlfmt",
Comment on lines -18 to -31

@4og 4og Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are python and yaml formatters removed?

@AlexanderLanin AlexanderLanin Jun 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have been moved to devcontainer 2 months ago. See eclipse-score/docs-as-code#614

@MaximilianSoerenPollak MaximilianSoerenPollak Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you meant to link this PR:
eclipse-score/devcontainer#116

workspace = "//:MODULE.bazel",
visibility = ["//visibility:public"],
)
15 changes: 0 additions & 15 deletions python_basics/multitool.lock.json
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions tools/BUILD
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions tools/README.md
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions tools/actionlint.lock.json
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions tools/ruff.lock.json
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions tools/sample.sh
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions tools/shellcheck.lock.json
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions tools/yamlfmt.lock.json
View file
Open in desktop

This file was deleted.

Loading