fix(collector): pass storageClassName to generated StatefulSet PVC#1963
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Collector-generated StatefulSet PVC templates to preserve the user-specified storageClassName, aligning Collector behavior with expected PVC configuration and addressing #1962.
Changes:
- Pass
spec.pvc.spec.storageClassNamethrough to the generatedStatefulSet.spec.volumeClaimTemplates[].spec.storageClassName.
Comment on lines
172
to
+176
| Spec: corev1.PersistentVolumeClaimSpec{ | ||
| AccessModes: bufferPvc.AccessModes, | ||
| Resources: bufferPvc.Resources, | ||
| VolumeMode: bufferPvc.VolumeMode, | ||
| AccessModes: bufferPvc.AccessModes, | ||
| Resources: bufferPvc.Resources, | ||
| VolumeMode: bufferPvc.VolumeMode, | ||
| StorageClassName: bufferPvc.StorageClassName, |
Collaborator
|
Hi @acidroper , Thanks for your contributions, but can you please fix the DCO check first? |
Signed-off-by: Andrey <inflamy@gmail.com>
acidroper
force-pushed
the
fix/collector-storageclass-pvc
branch
from
8b25585 to
a489bdb
Compare
cw-Guo
approved these changes
May 28, 2026
Collaborator
|
@acidroper Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1962
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: