fix: avoid panics on unsupported logger types#290
Open
happysnaker wants to merge 1 commit into
Open
Conversation
Author
|
This should be ready for review on my side. I have already signed the HashiCorp CLA previously, but the Change summary:
|
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.Loggervalues as a runtime panicLoggerorLeveledLoggerWhy
The current
Client.logger()path panics during request execution whenClient.Loggeris set to an unsupported type. That turns a configuration mistake into a production crash.This patch keeps the existing supported logger behavior unchanged, but treats unsupported logger values the same way as no logger for internal logging paths. Requests still complete, hooks still run, and applications no longer crash at runtime because of an invalid logger assignment.
Closes #243.