Fixed rendering of fractions in highest averages table in Model P 22-2#3461
Merged
Conversation
b27dc39 to
de49c7f
Compare
Contributor
I don't think this is too difficult, I'll see if I can change it to at least render using the inputs in |
Contributor
See #3464 |
stacktraceghost
approved these changes
Jun 25, 2026
praseodym
approved these changes
Jun 25, 2026
praseodym
left a comment
Contributor
There was a problem hiding this comment.
Looks like the new PDF diff works well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The rendering of fractions in the highest averages table had broken with a change in #3436
This PR fixes this.
How to test
Render a PDF with one of the gte-19-seats inputs and/or check the below PDFs.
Broken PDF (see page 9):
templates-3.pdf
Fixed PDF (see page 9):
templates-2.pdf
Reviewer notes
Unfortunately we missed this in the initial review, it would help to have the PDF diff check render all the variants, but this will be quite a refactor I think :/