Skip to content

Fixed rendering of fractions in highest averages table in Model P 22-2#3461

Merged
Lionqueen94 merged 2 commits into
mainfrom
fix_model_p_22_2_highest_average_table
Jun 25, 2026
Merged

Fixed rendering of fractions in highest averages table in Model P 22-2#3461
Lionqueen94 merged 2 commits into
mainfrom
fix_model_p_22_2_highest_average_table

Conversation

@Lionqueen94

@Lionqueen94 Lionqueen94 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What & why

The rendering of fractions in the highest averages table had broken with a change in #3436
This PR fixes this.

How to test

Render a PDF with one of the gte-19-seats inputs and/or check the below PDFs.

Broken PDF (see page 9):
templates-3.pdf

Fixed PDF (see page 9):
templates-2.pdf

Reviewer notes

Unfortunately we missed this in the initial review, it would help to have the PDF diff check render all the variants, but this will be quite a refactor I think :/

@Lionqueen94 Lionqueen94 self-assigned this Jun 23, 2026
@Lionqueen94 Lionqueen94 added the typst Typst templates label Jun 23, 2026
@Lionqueen94 Lionqueen94 force-pushed the fix_model_p_22_2_highest_average_table branch from b27dc39 to de49c7f Compare June 23, 2026 20:11
@Lionqueen94 Lionqueen94 marked this pull request as ready for review June 23, 2026 20:16
@Lionqueen94 Lionqueen94 requested a review from a team as a code owner June 23, 2026 20:16
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (2c4eef8) to head (de49c7f).

@Lionqueen94 Lionqueen94 moved this from Options to In Progress in Abacus Development Jun 23, 2026
@Lionqueen94 Lionqueen94 enabled auto-merge June 23, 2026 20:22
@praseodym

Copy link
Copy Markdown
Contributor

it would help to have the PDF diff check render all the variants, but this will be quite a refactor I think :/

I don't think this is too difficult, I'll see if I can change it to at least render using the inputs in backend/templates/inputs/extra-model-p-22-2-variations.

@praseodym

Copy link
Copy Markdown
Contributor

it would help to have the PDF diff check render all the variants, but this will be quite a refactor I think :/

I don't think this is too difficult, I'll see if I can change it to at least render using the inputs in backend/templates/inputs/extra-model-p-22-2-variations.

See #3464

@praseodym praseodym left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new PDF diff works well!

@Lionqueen94 Lionqueen94 added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit 1e8b788 Jun 25, 2026
22 checks passed
@Lionqueen94 Lionqueen94 deleted the fix_model_p_22_2_highest_average_table branch June 25, 2026 14:18
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Abacus Development Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typst Typst templates

Projects

Development

Successfully merging this pull request may close these issues.

3 participants