Skip to content

Expand PDF diff with P 22-2 variants#3464

Merged
stacktraceghost merged 1 commit into
mainfrom
pdf-diff-extra-variants
Jun 25, 2026
Merged

Expand PDF diff with P 22-2 variants#3464
stacktraceghost merged 1 commit into
mainfrom
pdf-diff-extra-variants

Conversation

@praseodym

Copy link
Copy Markdown
Contributor

What & why

Expand PDF diff with P 22-2 variants as noted in #3461 (comment). All variants are configured in backend/src/bin/gen-pdf.rs, which now also writes a manifest file that pdf-diff.js uses to link PDF files to the Typst templates.

How to test

See CI. Because the manifest doesn't exist for main, all PDF files will probably get reported as new.

Reviewer notes

None.

@praseodym praseodym self-assigned this Jun 24, 2026
@praseodym praseodym requested a review from a team as a code owner June 24, 2026 13:50
@praseodym praseodym added the continuous-integration Continuous integration (GitHub Actions) label Jun 24, 2026
@praseodym praseodym moved this from Options to In Progress in Abacus Development Jun 24, 2026
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.10%. Comparing base (2c4eef8) to head (5565961).
⚠️ Report is 2 commits behind head on main.

@Lionqueen94 Lionqueen94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing that we can add the variants now! 😄
It seems like the artifact upload goes wrong though:
No files were found with the provided path: backend/tmp-pdf-gen/diffs/. No artifacts will be uploaded.
The zip download results in a 404 right now.

@praseodym

Copy link
Copy Markdown
Contributor Author

See CI. Because the manifest doesn't exist for main, all PDF files will probably get reported as new.

All files get reported as 'New'

It seems like the artifact upload goes wrong though:
No files were found with the provided path: backend/tmp-pdf-gen/diffs/. No artifacts will be uploaded.
The zip download results in a 404 right now.

Because all files are new, there is nothing to diff in this branch

@Lionqueen94

Copy link
Copy Markdown
Contributor

See CI. Because the manifest doesn't exist for main, all PDF files will probably get reported as new.

All files get reported as 'New'

It seems like the artifact upload goes wrong though:
No files were found with the provided path: backend/tmp-pdf-gen/diffs/. No artifacts will be uploaded.
The zip download results in a 404 right now.

Because all files are new, there is nothing to diff in this branch

Ah I expected to have files with fully new text, but I guess nothing to diff against and then not showing the file at all makes sense.

@stacktraceghost stacktraceghost added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit 3c08101 Jun 25, 2026
22 checks passed
@stacktraceghost stacktraceghost deleted the pdf-diff-extra-variants branch June 25, 2026 13:03
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Abacus Development Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous-integration Continuous integration (GitHub Actions)

Projects

Development

Successfully merging this pull request may close these issues.

3 participants