Fix markdown shortcode regex dropping text around inner brackets#2844
Draft
CollinBeczak wants to merge 1 commit into
Draft
Fix markdown shortcode regex dropping text around inner brackets#2844CollinBeczak wants to merge 1 commit into
CollinBeczak wants to merge 1 commit into
Conversation
The shortcode tokenizer regex allowed `[` inside bracketed content, so input like `[HIDDEN TEXT [way 2343242]]` was matched as one shortcode and OSMElementHandler then extracted only the OSM element, silently dropping the surrounding text. The `[[way 1]]` form lost one bracket the same way. Excluding `[` from the inner character class makes the regex match only the innermost brackets, leaving surrounding text untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shortcode tokenizer regex allowed
[inside bracketed content, so input like[HIDDEN TEXT [way 2343242]]was matched as one shortcode and OSMElementHandler then extracted only the OSM element, silently dropping the surrounding text. The[[way 1]]form lost one bracket the same way.Excluding
[from the inner character class makes the regex match only the innermost brackets, leaving surrounding text untouched.