Skip to content

Fix markdown shortcode regex dropping text around inner brackets #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CollinBeczak wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Draft

Fix markdown shortcode regex dropping text around inner brackets #2844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/services/Templating/Templating.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ const shortCodeHandlers = [
// Short codes are surrounded by brackets, but -- to avoid confusion with
// Markdown links -- cannot be immediately followed by an open parenthesees
// (hence the lookahead at the end). Alternatively, triple curly braces can be
// used
const shortCodeRegex = /(\{\{\{[^}]+}}})|(\[[^\]]+\])(?=[^(]|$)/;
// used. The bracket form excludes `[` from its content so the regex matches
// the innermost brackets and leaves surrounding text (e.g. `[[way 1]]` or
// `[note [way 1]]`) intact rather than greedily swallowing it.
const shortCodeRegex = /(\{\{\{[^}]+}}})|(\[[^\][]+\])(?=[^(]|$)/;

/**
* Determines if the given string content contains one or more short-codes
Expand Down
Loading