Remove old env vars#717
Open
patrikk0123 wants to merge 4 commits into
Open
Conversation
patrikk0123
commented
Jun 9, 2026
| !pncUrl.startsWith(window.location.origin) && | ||
| !( | ||
| import.meta.env.VITE_WEB_UI_URL === window.location.origin || | ||
| import.meta.env.VITE_WEB_SECONDARY_UI_URL === window.location.origin |
Member
Author
There was a problem hiding this comment.
I think these are no longer needed because UI runs on the same URL as REST API
Member
Author
|
I'd also remove
|
patrikk0123
force-pushed
the
remove-deprecated
branch
from
9581ad1 to
3cccfc4
Compare
matedo1
reviewed
Jun 10, 2026
| const preDefinedScmsPrefix: { [key: string]: string } = { | ||
| [import.meta.env.VITE_GERRIT_URL_BASE || 'code']: 'Gerrit', | ||
| [import.meta.env.VITE_GERRIT_STAGE_URL_BASE || 'code']: 'Gerrit', | ||
| ['code']: 'Gerrit', |
Collaborator
There was a problem hiding this comment.
Hi @jomrazek , can you please confirm this change is safe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.