Skip to content

Remove old env vars #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrikk0123 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove old env vars #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0e80ab
Remove PNC API mocks client
patrikk0123 Jun 9, 2026
e383198
Remove link to Old UI
patrikk0123 Jun 9, 2026
aa3201e
Remove VITE_WEB_UI_URL env var usage
patrikk0123 Jun 9, 2026
3cccfc4
Remove Gerrit env var usage
patrikk0123 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/AppLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,6 @@ export const AppLayout = () => {
<RestrictedContent key="administration" role={AUTH_ROLE.Admin}>
<DropdownLinkItem to="/admin/administration">Administration</DropdownLinkItem>
</RestrictedContent>
{import.meta.env.VITE_PNC_OLD_UI_WEB && (
<DropdownLinkItem key="old-ui" to={import.meta.env.VITE_PNC_OLD_UI_WEB}>
Old UI Version <ExternalLinkAltIcon />
</DropdownLinkItem>
)}
</>
);

Expand Down
5 changes: 1 addition & 4 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ const App = () => {
if (
// https://example.com
!pncUrl.startsWith(window.location.origin) &&
!(
import.meta.env.VITE_WEB_UI_URL === window.location.origin ||
import.meta.env.VITE_WEB_SECONDARY_UI_URL === window.location.origin

@patrikk0123 patrikk0123 Jun 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are no longer needed because UI runs on the same URL as REST API

) &&
window.location.origin !== import.meta.env.VITE_WEB_SECONDARY_UI_URL &&
// example.com
window.location.hostname !== 'localhost'
) {
Expand Down
33 changes: 0 additions & 33 deletions src/services/pncApiMocksClient.ts
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/services/webConfigService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,20 +122,6 @@ export const getUILoggerUrl = (): string => {
return uiLoggerUrl;
};

/**
* Return PNC API mocks endpoint URL
*/
export const getPncApiMocksUrl = (): string => {
// TODO: extract URL from config once available
const pncApiMocksUrl = import.meta.env.VITE_PNC_API_MOCKS_URL;

if (!pncApiMocksUrl) {
throw new Error(`PNC API MOCKS URL does not contain any data: #${pncApiMocksUrl}#`);
}

return pncApiMocksUrl;
};

/**
* Return Kafka endpoint URL
*/
Expand Down
3 changes: 1 addition & 2 deletions src/utils/urlParseHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ interface IScmRepositoryUrl {
}

const preDefinedScmsPrefix: { [key: string]: string } = {
[import.meta.env.VITE_GERRIT_URL_BASE || 'code']: 'Gerrit',
[import.meta.env.VITE_GERRIT_STAGE_URL_BASE || 'code']: 'Gerrit',
['code']: 'Gerrit',

@matedo1 matedo1 Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jomrazek , can you please confirm this change is safe?

@jomrazek jomrazek Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that should be fine.

gitlab: 'GitLab',
github: 'GitHub',
};
Expand Down
Loading