Skip to content

Add QCS615 LYRA EVK platform#829

Draft
kranthi-peruri wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
kranthi-peruri:qcom-6.18.y_lyra
Draft

Add QCS615 LYRA EVK platform#829
kranthi-peruri wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
kranthi-peruri:qcom-6.18.y_lyra

Conversation

@kranthi-peruri

@kranthi-peruri kranthi-peruri commented Jul 15, 2026

Copy link
Copy Markdown

Add the device tree for the QCS615-based Lyra EVK platform. The
platform is composed of a System-on-Module following the SMARC
standard, and a Carrier Board.

The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interface
- Wi-Fi/BT

…yra evk board

Add the device tree for the QCS615-based Lyra EVK platform. The
platform is composed of a System-on-Module following the SMARC
standard, and a Carrier Board.

The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interface
- Wi-Fi/BT

Signed-off-by: Kranthi Peruri <kperuri@qti.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #829 — validate-patch

PR: #829

Verdict Issues Detailed Report
8 Full report

Final Summary

  1. Lore link present: No — FROMLIST: prefix used but no Link: https://lore.kernel.org/r/<message-id> tag found in commit message
  2. Lore link matches PR commits: N/A — cannot compare without a lore link
  3. Upstream patch status: Unknown — cannot verify upstream review status without lore link
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #829 - FROMLIST: arm64: dts: qcom: qsc615-lyra-evk: Add support for QCS615 lyra evk board
Upstream commit: N/A (no lore link found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Cannot verify - no lore link to compare against
Body preserves rationale Cannot verify - no lore link to compare against
Fixes tag present/correct N/A Not a fix commit
Authorship preserved Cannot verify - no lore link to compare against
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Cannot verify against upstream - no lore link
arch/arm64/boot/dts/qcom/talos-lyra-evk.dts Cannot verify against upstream - no lore link

Issues

Critical: Missing lore.kernel.org link

  • The commit uses the FROMLIST: prefix, which indicates the patch was posted to a mailing list
  • Per kernel commit message conventions, FROMLIST: commits must include a Link: https://lore.kernel.org/r/<message-id> tag
  • No lore link was found in the commit message

Subject line inconsistency

  • Subject mentions "qsc615-lyra-evk" but the actual DTS file created is talos-lyra-evk.dts
  • This naming mismatch suggests either the subject or filename needs correction

Integration presence failure

  • Commit is missing from both qcom-next and kernel topic branches
  • For a FROMLIST: commit, this is expected if the patch is still under review upstream
  • However, without a lore link, the upstream review status cannot be verified

Verdict

Do not merge. This commit cannot be validated because it lacks the required lore.kernel.org link. The FROMLIST: prefix indicates this patch was posted to a mailing list, but without a Link tag, reviewers cannot:

  1. Verify the patch content matches what was posted upstream
  2. Check the upstream review status and community feedback
  3. Confirm authorship and sign-off chain integrity
  4. Track the patch through the upstream acceptance process

Final Summary

  1. Lore link present: No — FROMLIST: prefix used but no Link: https://lore.kernel.org/r/<message-id> tag found in commit message
  2. Lore link matches PR commits: N/A — cannot compare without a lore link
  3. Upstream patch status: Unknown — cannot verify upstream review status without lore link
  4. PR present in qcom-next/topics: No — commit missing from both qcom-next and topics (per integration_presence_report.md: "FAIL - 1/1 commit(s) are missing from both qcom-next and topics")

Recommendation

Add a Link: https://lore.kernel.org/r/<message-id> line to the commit message pointing to the upstream mailing list posting, then re-run validation. If the patch has not yet been posted upstream, consider using the PENDING: prefix instead of FROMLIST: until it is actually posted to the mailing list.

Additionally, resolve the subject/filename inconsistency: either update the subject to reference "talos-lyra-evk" or rename the DTS file to "qsc615-lyra-evk.dts" to match the subject line.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: qsc615-lyra-evk: Add support for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #829 — checker-log-analyzer

PR: #829
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29420885373

Checker Result Summary
Checker Result Summary
checkpatch Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check USB node schema validation failures
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing Link: tag
tag-check FROMLIST: prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #829 - FROMLIST: arm64: dts: qcom: qsc615-lyra-evk: Add support for QCS615 lyra evk board
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29420885373

Checker Result Summary
checkpatch Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check USB node schema validation failures
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing Link: tag
tag-check FROMLIST: prefix present

❌ dtb-check

Root cause: The new talos-lyra-evk.dts includes talos-evk-som.dtsi, which contains USB nodes (usb@a600000, usb@a800000) that violate the qcom,snps-dwc3.yaml binding schema.

Failure details:

talos-lyra-evk.dtb: usb@a600000 (qcom,qcs615-dwc3): #address-cells: 1 was expected
talos-lyra-evk.dtb: usb@a600000 (qcom,qcs615-dwc3): #size-cells: 0 was expected
talos-lyra-evk.dtb: usb@a600000 (qcom,qcs615-dwc3): Unevaluated properties are not allowed 
  ('#address-cells', '#size-cells', 'dr_mode', 'phy-names', 'phys', 'ranges', 
   'snps,dis-u1-entry-quirk', 'snps,dis-u2-entry-quirk', 'snps,dis_enblslpm_quirk', 
   'snps,dis_u2_susphy_quirk', 'snps,dis_u3_susphy_quirk', 'snps,has-lpm-erratum', 
   'snps,hird-threshold', 'snps,usb3_lpm_capable' were unexpected)

talos-lyra-evk.dtb: usb@a800000 (qcom,qcs615-dwc3): #address-cells: 1 was expected
talos-lyra-evk.dtb: usb@a800000 (qcom,qcs615-dwc3): #size-cells: 0 was expected
talos-lyra-evk.dtb: usb@a800000 (qcom,qcs615-dwc3): Unevaluated properties are not allowed 
  ('#address-cells', '#size-cells', 'dr_mode', 'maximum-speed', 'phy-names', 'phys', 
   'ranges', 'snps,dis_enblslpm_quirk', 'snps,dis_u2_susphy_quirk', 'snps,dis_u3_susphy_quirk', 
   'snps,has-lpm-erratum', 'snps,hird-threshold' were unexpected)

Analysis:

This is a pre-existing tree issue in talos-evk-som.dtsi, not introduced by this PR. The PR only adds a new board DTS file that includes the existing SoM DTSI. The USB nodes in the included file have two problems:

  1. Wrong cell values: The binding expects #address-cells = <1> and #size-cells = <0>, but the nodes likely have #address-cells = <2> and #size-cells = <2> (inherited from parent or explicitly set).

  2. Unevaluated properties: The qcom,snps-dwc3.yaml binding uses unevaluatedProperties: false but doesn't declare many standard DWC3 properties (dr_mode, phy-names, phys, ranges, snps,* quirks). These properties should either be:

    • Added to the binding's properties: section, or
    • Allowed via unevaluatedProperties: true, or
    • Referenced via $ref to a parent schema that declares them

Fix:

This requires fixing the binding schema (Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml), not the DTS file:

# In qcom,snps-dwc3.yaml, add to properties section:
properties:
  '#address-cells':
    const: 1
  '#size-cells':
    const: 0
  dr_mode: true
  phy-names: true
  phys: true
  ranges: true
  maximum-speed: true
  
  # Add all snps,* properties or reference snps,dwc3.yaml
  snps,dis-u1-entry-quirk: true
  snps,dis-u2-entry-quirk: true
  snps,dis_enblslpm_quirk: true
  snps,dis_u2_susphy_quirk: true
  snps,dis_u3_susphy_quirk: true
  snps,has-lpm-erratum: true
  snps,hird-threshold: true
  snps,usb3_lpm_capable: true

OR reference the generic DWC3 binding:

allOf:
  - $ref: snps,dwc3.yaml#

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/talos-lyra-evk.dtb

Note: Since this is a pre-existing issue in the included DTSI file (not introduced by this PR), the PR author should either:

  1. Submit a separate patch to fix the binding schema first, or
  2. Coordinate with maintainers to fix the binding as part of the board enablement series

❌ check-patch-compliance

Root cause: The commit message has a FROMLIST: prefix but is missing the required Link: tag pointing to the upstream lore.kernel.org posting.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: qsc615-lyra-evk: Add support for QCS615 lyra evk board
No 'Link' found in commit message

Fix:

Add a Link: tag to the commit message body pointing to the lore.kernel.org URL where this patch was posted upstream:

git commit --amend

Then add before the Signed-off-by: line:

Link: https://lore.kernel.org/r/<message-id>
Signed-off-by: Kranthi Peruri <kperuri@qti.qualcomm.com>

If the patch hasn't been posted upstream yet, either:

  • Post it to the appropriate mailing list first, then add the Link, or
  • Change the prefix from FROMLIST: to PENDING: (though note that PENDING: will also fail check-patch-compliance as it's not in the allowed prefix list)

Reproduce locally:

# Verify the Link tag is present
git log -1 --format=%B 7774e974fdcf | grep -E "^Link:"

Verdict

2 blockers must be fixed before merge:

  1. dtb-check failure — Pre-existing binding schema issue in qcom,snps-dwc3.yaml. The binding must be updated to allow the DWC3 properties used in talos-evk-som.dtsi. This is not a defect in the PR itself, but the DTB validation will continue to fail until the binding is fixed.

  2. check-patch-compliance failure — Missing Link: tag. This is a mandatory fix for the PR commit message. Add the lore.kernel.org URL where this patch was posted upstream.

Recommendation: Fix the Link: tag immediately. For the dtb-check issue, coordinate with maintainers — either submit a binding fix patch first, or request that the binding be updated as part of reviewing this board enablement series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants