Skip to content

Wait timeout test refinement#1455

Merged
fjtirado merged 1 commit into
serverlessworkflow:mainfrom
fjtirado:Wait_timeouttest_refinement
Jun 12, 2026
Merged

Wait timeout test refinement#1455
fjtirado merged 1 commit into
serverlessworkflow:mainfrom
fjtirado:Wait_timeouttest_refinement

Conversation

@fjtirado

Copy link
Copy Markdown
Collaborator

Addressing AI comments from PR #1454

Copilot AI review requested due to automatic review settings June 12, 2026 15:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refines WaitExecutorTest to address prior PR feedback by tightening/clarifying wait-duration test coverage and reducing redundant or misleading test content.

Changes:

  • Clarified the disable reason for the seconds-based inline wait test.
  • Simplified the inline composite duration test by removing an incorrect/misleading comment.
  • Removed a redundant/misnamed ISO-8601 “composite” duration-literal test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java Outdated
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java Outdated
Copilot AI review requested due to automatic review settings June 12, 2026 15:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java Outdated
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java Outdated
@fjtirado fjtirado force-pushed the Wait_timeouttest_refinement branch from 64f0cea to a7222d3 Compare June 12, 2026 15:46
Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: fjtirado <ftirados@ibm.com>
@fjtirado fjtirado force-pushed the Wait_timeouttest_refinement branch from a7222d3 to 35a658a Compare June 12, 2026 15:50
Copilot AI review requested due to automatic review settings June 12, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@fjtirado fjtirado merged commit 3ac23d9 into serverlessworkflow:main Jun 12, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants