Skip to content

Wait timeout test refinement #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Jun 12, 2026
+3 −22
Merged

Wait timeout test refinement #1455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 3 additions & 22 deletions impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ static void tearDown() {
// ========== DurationInline Tests ==========

@Test
@Disabled("This one slow down")
@Disabled(
"Disabled because it waits 1s and slows the suite; DSL mapping is covered by testWaitSecondsConvenienceMethod")
void testWaitWithDurationInlineSeconds() {
Workflow workflow =
WorkflowBuilder.workflow("wait-inline-seconds", "test", "0.1.0")
Expand Down Expand Up @@ -87,7 +88,6 @@ void testWaitWithDurationInlineMilliseconds() {

@Test
void testWaitWithDurationInlineComposite() {
// Test composite duration with multiple components
Workflow workflow =
WorkflowBuilder.workflow("wait-inline-composite", "test", "0.1.0")
.tasks(DSL.wait(Duration.ofMillis(100).plusMillis(100)))
Expand All @@ -98,7 +98,7 @@ void testWaitWithDurationInlineComposite() {
long elapsed = System.currentTimeMillis() - startTime;

assertThat(model).isNotNull();
assertThat(elapsed).isGreaterThanOrEqualTo(200); // 1 second + 500 milliseconds
assertThat(elapsed).isGreaterThanOrEqualTo(200);
}

// ========== DurationLiteral Tests (TimeoutAfter.durationLiteral) ==========
Expand All @@ -122,25 +122,6 @@ void testWaitWithDurationLiteralISO8601Seconds() {
assertThat(elapsed).isGreaterThanOrEqualTo(1000);
}

@Test
void testWaitWithDurationLiteralISO8601Composite() {
Comment thread
fjtirado marked this conversation as resolved.
Workflow workflow =
WorkflowBuilder.workflow("wait-literal-composite", "test", "0.1.0")
.tasks(
list ->
list.wait(
w ->
w.build().setWait(new TimeoutAfter().withDurationExpression("PT0.1S"))))
.build();

long startTime = System.currentTimeMillis();
WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join();
long elapsed = System.currentTimeMillis() - startTime;

assertThat(model).isNotNull();
assertThat(elapsed).isGreaterThanOrEqualTo(100);
}

@Test
void testWaitWithDurationLiteralISO8601Milliseconds() {
// PT0.1S = 100 milliseconds
Expand Down
Loading