apollo_deployments: regression test generator on real overlay overrides#14572
Closed
nimrod-starkware wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 21, 2026
Contributor
Author
|
This change is |
nimrod-starkware
force-pushed
the
nimrod/jsonnet/real-overlay-regression
branch
from
4e77edd to
a168691
Compare
nimrod-starkware
changed the base branch from
nimrod/jsonnet/override-schema-from-eval
to
graphite-base/14572
nimrod-starkware
force-pushed
the
nimrod/jsonnet/real-overlay-regression
branch
from
a168691 to
d2a113e
Compare
nimrod-starkware
force-pushed
the
graphite-base/14572
branch
from
6948beb to
146f86f
Compare
nimrod-starkware
changed the base branch from
graphite-base/14572
to
nimrod/jsonnet/configmap-generator-optin
The generator's node-loadable test only exercised testing/overrides. Add a regression that drives it from a real environment's overlay sequencerConfig (the flat dotted, #is_none-marked overrides the deploy feeds the generator), read at test time from the committed YAML overlays (the single source of truth) so it never drifts. The test merges the sepolia-integration hybrid overlays the way the deploy does: the shared `common` overlay, the `sepolia-integration` overlay (which overrides common), and `dummy_for_testing` (layered last, supplying the per-pod instance values: P2P multiaddrs as dummy None and validator_id). Each layer's common.yaml + services/*.yaml contribute their config.sequencerConfig entries; later layers win. Parsing uses serde_yml (added as a dev-dependency). The test asserts (1) the overlay covers every override path the generator reads, so the generator builds a full config for the environment from the overlay alone, and (2) the overrides apply through the generator into node-loadable, validated configs for every hybrid service, with the environment's real values surviving (multiaddrs fold to null from their dummy #is_none markers; validator_id and chain_id are the overlay's own values). The per-service node-load assertion is extracted into a shared helper reused by the existing testing-overrides test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/configmap-generator-optin
branch
from
146f86f to
e1d94f0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/real-overlay-regression
branch
from
d2a113e to
5dce337
Compare
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator's node-loadable test only exercised testing/overrides. Add
a regression that drives it from a real environment's complete merged
overlay sequencerConfig (the flat dotted, #is_none-marked overrides the
deploy feeds the generator), vendored as a fixture: the sepolia-
integration config assembled across the in-repo layers (configs/layouts
per-pod instance values the external deploy repo supplies (P2P
multiaddrs and validator_id).
The test asserts (1) the overlay covers every override path the
generator reads, so the generator can build a full config for the
environment from the overlay alone (no synthetic completion), and (2)
the overrides apply through the generator into node-loadable, validated
configs for every hybrid service, with the environment's real values
surviving into the built config (advertised_multiaddr folds to null from
its #is_none marker; bootstrap peer, validator_id, and chain_id are the
overlay's own values). Both the coverage check and the value-survival
checks are exercised by mutation testing.
The per-service node-load assertion is extracted into a shared helper
reused by the existing testing-overrides test.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com