apollo_deployments: node-loadable regression across all layouts#14573
Closed
nimrod-starkware wants to merge 1 commit into
Closed
apollo_deployments: node-loadable regression across all layouts#14573nimrod-starkware wants to merge 1 commit into
nimrod-starkware wants to merge 1 commit into
Conversation
|
This change is |
This was referenced Jun 21, 2026
Contributor
Author
This was referenced Jun 21, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/real-overlay-regression
branch
from
4e77edd to
a168691
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/node-loadable-all-layouts
branch
from
75ba162 to
98b0503
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/real-overlay-regression
branch
from
a168691 to
d2a113e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/node-loadable-all-layouts
branch
from
98b0503 to
f6f8bf0
Compare
The generator node-loadable test only built the hybrid layout. Extend it to every layout (consolidated, hybrid, distributed) so each layout's per-service config is proven to round-trip through the node loader and pass validate_node_config — in particular the cross-member rule that each <component>_config is set iff that component runs locally, which differs per layout (consolidated runs everything in one service; distributed spreads components across services). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/node-loadable-all-layouts
branch
from
f6f8bf0 to
abeeb4c
Compare
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator node-loadable test only built the hybrid layout. Extend it
to every layout (consolidated, hybrid, distributed) so each layout's
per-service config is proven to round-trip through the node loader and
pass validate_node_config — in particular the cross-member rule that
each _config is set iff that component runs locally, which
differs per layout (consolidated runs everything in one service;
distributed spreads components across services).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com