Skip to content

apollo_deployments: node-loadable regression across all layouts #14573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nimrod-starkware wants to merge 1 commit into from
Closed

apollo_deployments: node-loadable regression across all layouts #14573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/apollo_deployments/src/jsonnet_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,17 @@ pub fn test_generator_flat_input_matches_direct_build() {
);
}

/// The generator's flat output is node-loadable, valid, and faithful: for every hybrid service,
/// feeding `service_config_to_preset` (the binary's output) through the node's real loader
/// The generator's flat output is node-loadable, valid, and faithful: for every service of every
/// layout, feeding `service_config_to_preset` (the binary's output) through the node's real loader
/// (`SequencerNodeConfig::load_and_process`, which resolves `CONFIG_POINTERS` + `#is_none`)
/// reconstructs exactly the `SequencerNodeConfig` that `build` produced and passes
/// `validate_node_config` — in particular the cross-member rule that each `<component>_config` is
/// set iff that component runs locally, which is what the per-service-tailored `build` satisfies.
/// Uses `testing/overrides`.
pub fn test_generator_config_is_node_loadable() {
assert_built_services_node_loadable(&eval_test_build("hybrid"));
for node_type in NodeType::iter() {
assert_built_services_node_loadable(&eval_test_build(&node_type.to_string()));
}
}

/// For every service in a `build(...)` result, feeds `service_config_to_preset` (the binary's
Expand Down
Loading