TS strict (1/4): type annotations, dead-code cleanup, strict-error CI infra#3686
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
commented
Jul 17, 2026
|
|
||
| <!-- Info Alert --> | ||
| <Alert intent="info" class="text-sm"> | ||
| <Icon name="info" slot="icon" /> |
Contributor
Author
There was a problem hiding this comment.
this slot does not exist in Alert and apparently never did??? the Icon is chosen from the Alert icon prop which defaults to intent prop
tegan-temporal
commented
Jul 17, 2026
| import allEventTypesFixture from '$fixtures/all-event-types.json'; | ||
|
|
||
| const events = allEventTypesFixture as unknown as CommonHistoryEvent[]; | ||
| const events = allEventTypesFixture as unknown as Record< |
Contributor
Author
There was a problem hiding this comment.
This is the accurate shape, it's not an array
andrewzamojc
approved these changes
Jul 17, 2026
andrewzamojc
left a comment
andrewzamojc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. All safe stuff 👍
tegan-temporal
commented
Jul 17, 2026
| @@ -1,4 +1,6 @@ | |||
| export const workflowStartedEvent = { | |||
| import type { PotentiallyDecodable } from './decode-payload'; | |||
Contributor
Author
There was a problem hiding this comment.
Review this file with by hiding whitespace changes, the diff is weird due to the whitespace change
Zero runtime impact: noImplicitAny type annotations, import type conversions, Storybook/test typing, and dead-code removal. No CI/enforcement changes here.
tegan-temporal
force-pushed
the
strict/1-base
branch
from
July 17, 2026 16:46
1b28a4f to
4c59793
Compare
tegan-temporal
enabled auto-merge (squash)
July 17, 2026 16:49
tegan-temporal
added a commit
that referenced
this pull request
Jul 17, 2026
Mechanical null-safety: nullish-coalescing defaults, optional chaining,
{#if} render guards, and generics-driven refactors. Behavior-preserving.
Rebased onto main after the base PR (#3686) merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of a 4-PR split of #3640 (enable TypeScript strict mode).
Zero runtime impact, no CI/enforcement changes. Contains only: noImplicitAny-driven type annotations,
import typeconversions, Storybook/test typing, and dead-code removal. 36 files.Global
strictstays off and the Danger strict-error check stays in warn mode until the final PR — so merging this early blocks nothing. All files verified strict-clean.Stack (merge bottom-up):
strict/1-base— type annotations + dead-code cleanup (zero runtime)strict/2-mechanical— strictNullChecks null-safety guardsstrict/3-behavior— runtime-affecting model/form/service changests-strict-mode— flipstrict: true+ enforce in CISplit verified: stacking all four reproduces the original combined tree byte-for-byte.